[MMBASE CVS] contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/core PortalURL.java PortalEnvironment.java

[Nico Klasens]

Update of 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/core
In directory 
james.mmbase.org:/tmp/cvs-serv19747/cmsc/portal/src/java/com/finalist/pluto/portalImpl/core

Modified Files:
        PortalURL.java PortalEnvironment.java 
Log Message:
CMSC-907 Code Quality with PMD
PMD error fixes


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/core
See also: http://www.mmbase.org/jira/browse/CMSC-907


Index: PortalURL.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/core/PortalURL.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -b -r1.14 -r1.15
--- PortalURL.java      21 Apr 2008 10:11:52 -0000      1.14
+++ PortalURL.java      9 Jun 2008 21:23:24 -0000       1.15
@@ -148,7 +148,7 @@
     * @param nav
     *           the string pointing to a portal part
     */
-   public void addGlobalNavigation(String nav) {
+   public final void addGlobalNavigation(String nav) {
       startGlobalNavigation.add(nav);
    }
 
@@ -221,7 +221,7 @@
       if (iterator.hasNext()) {
          result.append(iterator.next());
          while (iterator.hasNext()) {
-            result.append("/");
+            result.append('/');
             String st = iterator.next();
             result.append(st);
          }
@@ -257,14 +257,14 @@
       Set<String> encodedNames = new 
TreeSet<String>(encodedStateFullParams.keySet());
       Iterator<String> iterator = encodedNames.iterator();
       while (iterator.hasNext()) {
-         result.append("/");
+         result.append('/');
          String encodedName = iterator.next();
          String encodedValue = (String) 
encodedStateFullParams.get(encodedName);
          if (encodedValue != null) {
             // appends the prefix (currently "_") in front of the encoded
             // parameter name
             
result.append(PortalControlParameter.encodeParameterName(encodedName));
-            result.append("/");
+            result.append('/');
             result.append(urlEncode(encodedValue));
          }
       }
@@ -318,6 +318,7 @@
    }
 
 
+   @Override
    public String toString() {
       return toString(null, null);
    }
@@ -344,7 +345,7 @@
 
       String global = getGlobalNavigationAsString();
       if (global.length() > 0) {
-         url.append("/");
+         url.append('/');
          url.append(global);
       }
 
@@ -392,8 +393,9 @@
 
 
    void analyzeRequestInformation() {
-      if (analyzed)
+      if (analyzed) {
          return;
+      }
 
       startGlobalNavigation = new ArrayList<String>();
       startLocalNavigation = new ArrayList<String>();


Index: PortalEnvironment.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/pluto/portalImpl/core/PortalEnvironment.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- PortalEnvironment.java      2 Jun 2008 21:56:34 -0000       1.6
+++ PortalEnvironment.java      9 Jun 2008 21:23:24 -0000       1.7
@@ -50,7 +50,7 @@
    }
 
 
-   public void registerEnvironment() {
+   public final void registerEnvironment() {
       // set Environment in Request for later use
       this.request.setAttribute(REQUEST_PORTALENV, this);
    }
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs