Update of 
/var/cvs/contributions/CMSContainer/cmsc/portlets/src/java/com/finalist/cmsc/portlets
In directory 
james.mmbase.org:/tmp/cvs-serv17459/cmsc/portlets/src/java/com/finalist/cmsc/portlets

Modified Files:
      Tag: b1_4
        RelatedContentPortlet.java 
Log Message:
CMSC-959 - formatting + javadoc


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/portlets/src/java/com/finalist/cmsc/portlets
See also: http://www.mmbase.org/jira/browse/CMSC-959


Index: RelatedContentPortlet.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/portlets/src/java/com/finalist/cmsc/portlets/RelatedContentPortlet.java,v
retrieving revision 1.4.2.2
retrieving revision 1.4.2.3
diff -u -b -r1.4.2.2 -r1.4.2.3
--- RelatedContentPortlet.java  12 Jun 2008 13:36:40 -0000      1.4.2.2
+++ RelatedContentPortlet.java  12 Jun 2008 14:57:58 -0000      1.4.2.3
@@ -3,6 +3,7 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collections;
+import java.util.List;
 import java.util.Set;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -12,6 +13,8 @@
 import javax.portlet.RenderResponse;
 import javax.servlet.http.HttpServletRequest;
 
+import net.sf.mmapps.commons.util.StringUtil;
+
 import org.apache.pluto.core.impl.PortletRequestImpl;
 
 import com.finalist.cmsc.beans.om.NavigationItem;
@@ -20,12 +23,10 @@
 import com.finalist.cmsc.portalImpl.PortalConstants;
 import com.finalist.cmsc.services.sitemanagement.SiteManagement;
 
-import net.sf.mmapps.commons.util.StringUtil;
-
 public class RelatedContentPortlet extends AbstractContentPortlet {
 
        /**
-        * This rexex pattern is uesd to match the elementId from a contentURL.
+    * This regex pattern is used to match the elementId from a contentURL.
         */
        private static final String CONTENTURL_ELEMENTID_PATTERN = 
"/content/([0-9]+)";
 
@@ -39,7 +40,7 @@
                                if (StringUtil.isEmpty(elementId)) {
                                        elementId = 
getElementIdFromContentURL(req);
                                        if (StringUtil.isEmpty(elementId)) {
-                                               elementId = getElementId(req);
+                  elementId = getElementId(req, window);
                                        }
                                }
                        }
@@ -51,43 +52,34 @@
                super.doView(req, res);
        }
 
+   @Override
+   protected void doEditDefaults(RenderRequest req, RenderResponse res) throws 
IOException, PortletException {
+      Integer pageid = getCurrentPageId(req);
+      String pagepath = SiteManagement.getPath(pageid, true);
+
+      if (pagepath != null) {
+         Set<String> positions = 
SiteManagement.getPagePositions(pageid.toString());
+         List<String> orderedPositions = new ArrayList<String>(positions);
+         Collections.sort(orderedPositions);
+         setAttribute(req, "pagepositions", new 
ArrayList<String>(orderedPositions));
+      }
+      super.doEditDefaults(req, res);
+   }
+
        /**
-        * This method can be overridden to provide your own mechanism for 
getting
-        * an elementId.
+    * This method can be overridden to provide your own mechanism for getting 
an
+    * elementId. The default implementation returns <code>null</code>.
         * 
         * @param req
         *            originating RenderRequest
-        * @return ElementId, defaults to null.
-        * 
+    * @param window
+    *           the passed 'window' parameter.
+    * @return the elementId
         */
-       protected String getElementId(RenderRequest req) {
-               // Extension point
+   protected String getElementId(RenderRequest req, String window) {
                return null;
        }
 
-       private String getElementIdFromScreen(RenderRequest req, String window) 
{
-               Integer pageId = getCurrentPageId(req);
-               NavigationItem item = SiteManagement.getNavigationItem(pageId);
-               if (item instanceof Page) {
-                       Page page = (Page) item;
-                       int portletId = page.getPortlet(window);
-                       Portlet portlet = SiteManagement.getPortlet(portletId);
-                       if (portlet != null) {
-                               return 
portlet.getParameterValue(CONTENTELEMENT);
-                       }
-               }
-               return null;
-       }
-
-       private Integer getCurrentPageId(RenderRequest req) {
-               String pageId = (String) 
req.getAttribute(PortalConstants.CMSC_OM_PAGE_ID);
-               return Integer.valueOf(pageId);
-       }
-
-       private HttpServletRequest getServletRequest(RenderRequest req) {
-               return (HttpServletRequest) ((PortletRequestImpl) 
req).getRequest();
-       }
-
        private String getElementIdFromRequestParameters(RenderRequest req, 
String window) {
                String requestURL = 
getServletRequest(req).getRequestURL().toString();
                String paramName = "/_rp_" + window + "_elementId/1_";
@@ -103,20 +95,6 @@
                return null;
        }
 
-       @Override
-       protected void doEditDefaults(RenderRequest req, RenderResponse res) 
throws IOException, PortletException {
-               Integer pageid = getCurrentPageId(req);
-               String pagepath = SiteManagement.getPath(pageid, true);
-
-               if (pagepath != null) {
-                       Set<String> positions = 
SiteManagement.getPagePositions(pageid.toString());
-                       ArrayList<String> orderedPositions = new 
ArrayList<String>(positions);
-                       Collections.sort(orderedPositions);
-                       setAttribute(req, "pagepositions", new 
ArrayList<String>(orderedPositions));
-               }
-               super.doEditDefaults(req, res);
-       }
-
        private String getElementIdFromContentURL(RenderRequest req) {
                String requestURL = 
getServletRequest(req).getRequestURL().toString();
                Pattern pattern = Pattern.compile(CONTENTURL_ELEMENTID_PATTERN);
@@ -126,4 +104,27 @@
                }
                return null;
        }
+
+   private String getElementIdFromScreen(RenderRequest req, String window) {
+      Integer pageId = getCurrentPageId(req);
+      NavigationItem item = SiteManagement.getNavigationItem(pageId);
+      if (item instanceof Page) {
+         Page page = (Page) item;
+         int portletId = page.getPortlet(window);
+         Portlet portlet = SiteManagement.getPortlet(portletId);
+         if (portlet != null) {
+            return portlet.getParameterValue(CONTENTELEMENT);
+         }
+      }
+      return null;
+   }
+
+   private Integer getCurrentPageId(RenderRequest req) {
+      String pageId = (String) 
req.getAttribute(PortalConstants.CMSC_OM_PAGE_ID);
+      return Integer.valueOf(pageId);
+   }
+
+   private HttpServletRequest getServletRequest(RenderRequest req) {
+      return (HttpServletRequest) ((PortletRequestImpl) req).getRequest();
+   }
 }
\ No newline at end of file
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs

Reply via email to