[MMBASE CVS] contributions/CMSContainer/cmsc/portal/src/java/com/finalist/cmsc/portalImpl PortletServlet.java

[jkoster]

Update of 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/cmsc/portalImpl
In directory 
james.mmbase.org:/tmp/cvs-serv21580/cmsc/portal/src/java/com/finalist/cmsc/portalImpl

Modified Files:
        PortletServlet.java 
Log Message:
CMSC-907 - Fixed bad code constructions and did some improvements


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/cmsc/portalImpl
See also: http://www.mmbase.org/jira/browse/CMSC-907


Index: PortletServlet.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/portal/src/java/com/finalist/cmsc/portalImpl/PortletServlet.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- PortletServlet.java 16 May 2008 06:40:01 -0000      1.4
+++ PortletServlet.java 3 Jul 2008 20:29:35 -0000       1.5
@@ -43,7 +43,7 @@
  * Servlet to handle Portlets
  * 
  * @author Wouter Heijke
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
  */
 public class PortletServlet extends HttpServlet {
    private static Log log = LogFactory.getLog(PortletServlet.class);
@@ -125,7 +125,7 @@
       try {
          portletClass = 
portletFactory.getPortletInstance(this.getServletContext(), portletDefinition);
          Integer method_id = (Integer) 
request.getAttribute(Constants.METHOD_ID);
-         if (method_id == Constants.METHOD_RENDER) {
+         if (method_id.equals(Constants.METHOD_RENDER)) {
             RenderRequest renderRequest = (RenderRequest) 
request.getAttribute(Constants.PORTLET_REQUEST);
             RenderResponse renderResponse = (RenderResponse) 
request.getAttribute(Constants.PORTLET_RESPONSE);
 
@@ -135,7 +135,7 @@
             
             portletClass.render(renderRequest, renderResponse);
          }
-         else if (method_id == Constants.METHOD_ACTION) {
+         else if (method_id.equals(Constants.METHOD_ACTION)) {
             ActionRequest actionRequest = (ActionRequest) 
request.getAttribute(Constants.PORTLET_REQUEST);
             ActionResponse actionResponse = (ActionResponse) 
request.getAttribute(Constants.PORTLET_RESPONSE);
 
@@ -145,7 +145,7 @@
 
             portletClass.processAction(actionRequest, actionResponse);
          }
-         else if (method_id == Constants.METHOD_NOOP) { // AKA Load
+         else if (method_id.equals(Constants.METHOD_NOOP)) { // AKA Load
             PortletContext portletContext = null;
             PortletConfig portletConfig = null;
 
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs