Update of 
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce
In directory james.mmbase.org:/tmp/cvs-serv18364/publisher/bounce

Modified Files:
        BounceChecker.java ReceiveThread.java 
Log Message:
CMSC-899,Check and improve all lists according to guideline


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce
See also: http://www.mmbase.org/jira/browse/CMSC-899


Index: BounceChecker.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/BounceChecker.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- BounceChecker.java  24 Jul 2008 11:45:43 -0000      1.2
+++ BounceChecker.java  22 Sep 2008 07:53:42 -0000      1.3
@@ -15,7 +15,7 @@
  *
  * @author Mark Guo <[EMAIL PROTECTED]>
  */
-public class BounceChecker extends Thread{
+public class BounceChecker extends Thread {
    private Logger log = 
Logging.getLoggerInstance(BounceChecker.class.getName());
 
    private static int LISTENINGPORT = 25;
@@ -23,7 +23,7 @@
    private static boolean stop = false;
    private NewsletterService newsletterService;
 
-   public BounceChecker(NewsletterService newsletterService){
+   public BounceChecker (NewsletterService newsletterService) {
       this.newsletterService = newsletterService;
    }
    public void run() {


Index: ReceiveThread.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/ReceiveThread.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- ReceiveThread.java  24 Jul 2008 11:45:43 -0000      1.2
+++ ReceiveThread.java  22 Sep 2008 07:53:42 -0000      1.3
@@ -27,7 +27,7 @@
    private NewsletterService newsletterService;
    private  String[] params;
 
-   SMTPSTATUS status = SMTPSTATUS.INIT;
+   private SMTPSTATUS status = SMTPSTATUS.INIT;
    public ReceiveThread() {
    }
    public ReceiveThread(Socket socket) {
@@ -113,8 +113,8 @@
 
          String username = recepient[0];
          if (username.startsWith("bounce-")) {
-            params = username.replace("bounce-","").split("=");
-            newsletterService.processBouncesOfPublication(params[0],params[1]);
+            params = username.replace("bounce-", "").split("=");
+            newsletterService.processBouncesOfPublication(params[0], 
params[1]);
          }
          writer.write("250 Yeah, OK. Bring on the data!\r\n");
          writer.flush();
@@ -135,14 +135,14 @@
                try {
                   Thread.sleep(50);
                } catch (InterruptedException e) {
-                  log.warn("Failed to read ",e);
+                  log.warn("Failed to read ", e);
                }
             }
             data.append((char) c);
             System.arraycopy(last5chars, 1, last5chars, 0, last5chars.length - 
1);
             last5chars[last5chars.length - 1] = (char) c;
          }
-         if(params != null) {
+         if (params != null) {
             newsletterService.processBouncesOfPublication(params[0], 
params[1], data.toString());
          }
          // ignore data for bounce message.
@@ -160,7 +160,7 @@
    private boolean verifyEndSymbol(char[] last5chars) {
 
       boolean isreading;
-      char[] endchars = {'\r', '\n','.', '\r', '\n'};
+      char[] endchars = {'\r', '\n', '.', '\r', '\n'};
       isreading = false;
       for (int i = 0; i < last5chars.length; i++) {
          if (last5chars[i] != endchars[i]) {
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs

Reply via email to