[MMBASE CVS] contributions/CMSContainer_Portlets/portlets-dynamicforms/src/java/com/finalist/portlets/responseform ResponseFormPortlet.java

[fpunt]

Update of 
/var/cvs/contributions/CMSContainer_Portlets/portlets-dynamicforms/src/java/com/finalist/portlets/responseform
In directory 
james.mmbase.org:/tmp/cvs-serv25552/portlets-dynamicforms/src/java/com/finalist/portlets/responseform

Modified Files:
      Tag: b1_5
        ResponseFormPortlet.java 
Log Message:
CMSC-1025 fixed, error message on forms with no user email field


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-dynamicforms/src/java/com/finalist/portlets/responseform
See also: http://www.mmbase.org/jira/browse/CMSC-1025


Index: ResponseFormPortlet.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer_Portlets/portlets-dynamicforms/src/java/com/finalist/portlets/responseform/ResponseFormPortlet.java,v
retrieving revision 1.21
retrieving revision 1.21.2.1
diff -u -b -r1.21 -r1.21.2.1
--- ResponseFormPortlet.java    10 Sep 2008 12:03:53 -0000      1.21
+++ ResponseFormPortlet.java    6 Oct 2008 14:06:20 -0000       1.21.2.1
@@ -254,20 +254,27 @@
             sent = true;
          }
          catch (UnsupportedEncodingException e) {
+            getLogger().error("error in mail data: userEmailText = '" + 
userEmailText +"' " +
+                       " userEmailSenderName = '" + userEmailSenderName +"' " +
+                       " userEmailAddress = '" + userEmailAddress +"' " +
+                       " userEmailSenderAddress = '" + userEmailSenderAddress 
+"' ");
             getLogger().error("error sending email", e);
          }
          catch (MessagingException e) {
-            getLogger().error("error sending email", e);
-         }
-      }
-      else {
           getLogger().error("error in mail data: userEmailText = '" + 
userEmailText +"' " +
                 " userEmailSenderName = '" + userEmailSenderName +"' " +
                 " userEmailAddress = '" + userEmailAddress +"' " +
                 " userEmailSenderAddress = '" + userEmailSenderAddress +"' ");
+            getLogger().error("error sending email", e);
+         }
+      }
+      else {
+         // no need to send, but there is need to tell it was a success
+          sent = true;
       }
       return sent;
    }
+   }
 
 
    private boolean sendResponseFormEmail(Node responseform, final String 
userEmailAddress, String responseformData,
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs