Update of
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter
In directory
james.mmbase.org:/tmp/cvs-serv24485/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter
Modified Files:
NewsletterSumLogsCronJob.java NewsletterSendFailException.java
NewsletterCronJob.java
Log Message:
CMSC-1091 improve code style.
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter
See also: http://www.mmbase.org/jira/browse/CMSC-1091
Index: NewsletterSumLogsCronJob.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/NewsletterSumLogsCronJob.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- NewsletterSumLogsCronJob.java 23 Sep 2008 07:41:58 -0000 1.4
+++ NewsletterSumLogsCronJob.java 14 Oct 2008 11:22:44 -0000 1.5
@@ -13,7 +13,6 @@
/**
* @author nikko
- *
*/
public class NewsletterSumLogsCronJob extends AbstractCronJob implements
CronJob {
@@ -33,14 +32,14 @@
@Override
public void run() {
StatisticService service = (StatisticService)
ApplicationContextFactory.getBean("statisticService");
- List < StatisticResult > listRecorder = service.getLogs();
+ List<StatisticResult> listRecorder = service.getLogs();
if (null != listRecorder) {
insetStatRecord(service, listRecorder);
listRecorder.clear();
}
}
- private int insetStatRecord(StatisticService service, List <
StatisticResult > listRecorder) {
+ private int insetStatRecord(StatisticService service, List<StatisticResult>
listRecorder) {
if (null != listRecorder) {
return service.pushSumedLogs(listRecorder);
} else {
Index: NewsletterSendFailException.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/NewsletterSendFailException.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- NewsletterSendFailException.java 22 Apr 2008 03:35:53 -0000 1.1
+++ NewsletterSendFailException.java 14 Oct 2008 11:22:44 -0000 1.2
@@ -1,6 +1,6 @@
package com.finalist.newsletter;
-public class NewsletterSendFailException extends RuntimeException{
+public class NewsletterSendFailException extends RuntimeException {
public NewsletterSendFailException() {
}
Index: NewsletterCronJob.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/NewsletterCronJob.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -b -r1.18 -r1.19
--- NewsletterCronJob.java 10 Sep 2008 11:48:09 -0000 1.18
+++ NewsletterCronJob.java 14 Oct 2008 11:22:44 -0000 1.19
@@ -50,30 +50,31 @@
private void createPublication(List<Node> newslettersToPublish, Node
newsletter,
Object scheduleExpression, Date lastCreatedDateTime) {
- String expression = (String)scheduleExpression;
+ String expression = (String) scheduleExpression;
String[] expressions = expression.split("\\|");
- if(isPublish(expressions,lastCreatedDateTime)) {
+ if (isPublish(expressions, lastCreatedDateTime)) {
newslettersToPublish.add(newsletter);
}
}
- private boolean isPublish(String[] expressions,Date lastCreatedDateTime) {
+ private boolean isPublish(String[] expressions, Date lastCreatedDateTime) {
boolean isPublish = false;
DateFormat df = new SimpleDateFormat("dd-MM-yyyy HH:mm");
Date minDate = null;
try {
minDate = df.parse("01-01-1970 00:00");
} catch (ParseException e) {
- log.debug("--> Parse date Exception");;
+ log.debug("--> Parse date Exception");
+ ;
}
Date now = new Date();
Calendar calender = Calendar.getInstance();
//expressions[0] value: 1 once
- if(expressions[0].equals("1")) {
- String startDatetime = expressions[1]+"
"+expressions[2]+":"+expressions[3];
+ if (expressions[0].equals("1")) {
+ String startDatetime = expressions[1] + " " + expressions[2] + ":" +
expressions[3];
try {
Date startDate = df.parse(startDatetime);
- if(now.after(startDate) && (lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime))) {
+ if (now.after(startDate) && (lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime))) {
isPublish = true;
}
}
@@ -82,30 +83,27 @@
}
}//expressions[0] : 2 daily
else if (expressions[0].equals("2")) {
- String startDatetime = expressions[1]+"
"+expressions[2]+":"+expressions[3];
+ String startDatetime = expressions[1] + " " + expressions[2] + ":" +
expressions[3];
try {
Date startDate = df.parse(startDatetime);
- if(now.after(startDate)) {
- if(expressions[4].equals("0")) {
+ if (now.after(startDate)) {
+ if (expressions[4].equals("0")) {
isPublish = compareDate(lastCreatedDateTime, isPublish,
minDate, now);
- }
- else if(expressions[4].equals("1")) {
- if(calender.get(Calendar.DAY_OF_WEEK) != Calendar.SATURDAY
&& calender.get(Calendar.DAY_OF_WEEK) != Calendar.SUNDAY) {
+ } else if (expressions[4].equals("1")) {
+ if (calender.get(Calendar.DAY_OF_WEEK) != Calendar.SATURDAY
&& calender.get(Calendar.DAY_OF_WEEK) != Calendar.SUNDAY) {
isPublish = compareDate(lastCreatedDateTime, isPublish,
minDate, now);
}
- }
- else if(expressions[4].equals("2")) {
+ } else if (expressions[4].equals("2")) {
int interval = Integer.parseInt(expressions[5]);
- if(lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)) {
- if(DateUtils.isSameDay(DateUtils.addDays(startDate,
interval),now)) {
+ if (lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)) {
+ if (DateUtils.isSameDay(DateUtils.addDays(startDate,
interval), now)) {
isPublish = true;
}
- }
- else {
-
if(DateUtils.isSameDay(DateUtils.addDays(lastCreatedDateTime, interval),now)) {
+ } else {
+ if
(DateUtils.isSameDay(DateUtils.addDays(lastCreatedDateTime, interval), now)) {
isPublish = true;
}
}
@@ -116,52 +114,50 @@
log.debug("--> Parse date Exception");
}
}//expressions[0] : 3 weekly
- else if(expressions[0].equals("3")) {
+ else if (expressions[0].equals("3")) {
Calendar startTime = getStartCalendar(expressions);
char[] weeks = expressions[4].toCharArray();
for (char week2 : weeks) {
String week = String.valueOf(week2);
- if((calender.get(Calendar.DAY_OF_WEEK) != 1 &&
calender.get(Calendar.DAY_OF_WEEK) == (Integer.parseInt(week)+1)) ||
(calender.get(Calendar.DAY_OF_WEEK) == 1 && Integer.parseInt(week) == 7)) {
- if(calender.after(startTime)) {
+ if ((calender.get(Calendar.DAY_OF_WEEK) != 1 &&
calender.get(Calendar.DAY_OF_WEEK) == (Integer.parseInt(week) + 1)) ||
(calender.get(Calendar.DAY_OF_WEEK) == 1 && Integer.parseInt(week) == 7)) {
+ if (calender.after(startTime)) {
try {
- if(lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)){
+ if (lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)) {
isPublish = true;
break;
- }
- else {
+ } else {
int interval = Integer.parseInt(expressions[3]);
Date beCreate =
DateUtils.addWeeks(lastCreatedDateTime, interval);
- if(DateUtils.isSameDay(new Date(),beCreate )) {
+ if (DateUtils.isSameDay(new Date(), beCreate)) {
isPublish = true;
break;
}
}
}
catch (NumberFormatException e) {
- log.debug("-->NumberFormatException "+e.getMessage());
+ log.debug("-->NumberFormatException " + e.getMessage());
}
}
}
}
}//expressions[0] : 4 monthly
- else if(expressions[0].equals("4")) {
+ else if (expressions[0].equals("4")) {
Calendar startTime = getStartCalendar(expressions);
- if(expressions[3].equals("0")) {
+ if (expressions[3].equals("0")) {
String dayOfMonth = expressions[4];
char[] months = expressions[5].toCharArray();
for (char month2 : months) {
String month = String.valueOf(month2);
- if(!month.equals("a") && !month.equals("b") &&
(Integer.parseInt(month) == calender.get(Calendar.MONTH)) || (month.equals("b")
&& calender.get(Calendar.MONTH) == 11) || (month.equals("a") &&
calender.get(Calendar.MONTH) == 10)) {
- if(calender.get(Calendar.DAY_OF_MONTH) ==
Integer.parseInt(dayOfMonth)) {
- if(calender.after(startTime)) {
- if(lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)){
+ if (!month.equals("a") && !month.equals("b") &&
(Integer.parseInt(month) == calender.get(Calendar.MONTH)) || (month.equals("b")
&& calender.get(Calendar.MONTH) == 11) || (month.equals("a") &&
calender.get(Calendar.MONTH) == 10)) {
+ if (calender.get(Calendar.DAY_OF_MONTH) ==
Integer.parseInt(dayOfMonth)) {
+ if (calender.after(startTime)) {
+ if (lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)) {
isPublish = true;
break;
- }
- else {
- if(!DateUtils.isSameDay(new
Date(),lastCreatedDateTime )) {
+ } else {
+ if (!DateUtils.isSameDay(new Date(),
lastCreatedDateTime)) {
isPublish = true;
break;
}
@@ -170,24 +166,22 @@
}
}
}
- }
- else if(expressions[3].equals("1")) {
+ } else if (expressions[3].equals("1")) {
String weekOfMonth = expressions[4];
String week = expressions[5];
char[] months = expressions[6].toCharArray();
for (char month2 : months) {
String month = String.valueOf(month2);
- if(!month.equals("a") && !month.equals("b") &&
(Integer.parseInt(month) == calender.get(Calendar.MONTH)) || (month.equals("a")
&& calender.get(Calendar.MONTH) == 10) || (month.equals("b") &&
calender.get(Calendar.MONTH) == 11)) {
- if(calender.get(Calendar.WEEK_OF_MONTH) ==
Integer.parseInt(weekOfMonth)) {
- if(calender.get(Calendar.DAY_OF_WEEK)!= 1 &&
calender.get(Calendar.DAY_OF_WEEK)== (Integer.parseInt(week)+1)) {
- if(calender.after(startTime)) {
- if(lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)){
+ if (!month.equals("a") && !month.equals("b") &&
(Integer.parseInt(month) == calender.get(Calendar.MONTH)) || (month.equals("a")
&& calender.get(Calendar.MONTH) == 10) || (month.equals("b") &&
calender.get(Calendar.MONTH) == 11)) {
+ if (calender.get(Calendar.WEEK_OF_MONTH) ==
Integer.parseInt(weekOfMonth)) {
+ if (calender.get(Calendar.DAY_OF_WEEK) != 1 &&
calender.get(Calendar.DAY_OF_WEEK) == (Integer.parseInt(week) + 1)) {
+ if (calender.after(startTime)) {
+ if (lastCreatedDateTime == null ||
DateUtils.isSameDay(minDate, lastCreatedDateTime)) {
isPublish = true;
break;
- }
- else {
- if(!DateUtils.isSameDay(new
Date(),lastCreatedDateTime )) {
+ } else {
+ if (!DateUtils.isSameDay(new Date(),
lastCreatedDateTime)) {
isPublish = true;
break;
}
@@ -211,11 +205,10 @@
private boolean compareDate(Date lastCreatedDateTime, boolean isPublish,
Date minDate, Date now) {
- if(lastCreatedDateTime == null || DateUtils.isSameDay(minDate,
lastCreatedDateTime)) {
+ if (lastCreatedDateTime == null || DateUtils.isSameDay(minDate,
lastCreatedDateTime)) {
isPublish = true;
- }
- else {
- if(!DateUtils.isSameDay(now, lastCreatedDateTime)) {
+ } else {
+ if (!DateUtils.isSameDay(now, lastCreatedDateTime)) {
isPublish = true;
}
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
