Update of
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce
In directory
james.mmbase.org:/tmp/cvs-serv24485/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce
Modified Files:
BounceChecker.java SMTPSTATUS.java ReceiveThread.java
Log Message:
CMSC-1091 improve code style.
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce
See also: http://www.mmbase.org/jira/browse/CMSC-1091
Index: BounceChecker.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/BounceChecker.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- BounceChecker.java 22 Sep 2008 07:53:42 -0000 1.3
+++ BounceChecker.java 14 Oct 2008 11:22:44 -0000 1.4
@@ -23,9 +23,10 @@
private static boolean stop = false;
private NewsletterService newsletterService;
- public BounceChecker (NewsletterService newsletterService) {
+ public BounceChecker(NewsletterService newsletterService) {
this.newsletterService = newsletterService;
}
+
public void run() {
log.debug("Start Bounce checking .....");
BounceChecker.running = true;
Index: SMTPSTATUS.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/SMTPSTATUS.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- SMTPSTATUS.java 18 Jul 2008 08:53:16 -0000 1.1
+++ SMTPSTATUS.java 14 Oct 2008 11:22:44 -0000 1.2
@@ -43,8 +43,8 @@
INIT.init("MAIL FROM:", "<MAILFROM", null, "503 That's not nice! Polite
people say HELO first\r\n");
INIT.init("MAIL FROM:", ">MAILFROM", null, "503 You cannot specify MAIL
FROM after a RCPT TO\r\n");
INIT.init("MAIL FROM:", "=MAILFROM", RCPTTO, "250 That address looks
okay, I'll allow you to send mail.\r\n");
- INIT.init("RCPT TO:", "<RCPTTO", null,"503 You should say MAIL FROM
first\r\n");
- INIT.init("RCPT TO:", ">=DATA", null,"503 You cannot use RCPT TO: at
this state\r\n");
+ INIT.init("RCPT TO:", "<RCPTTO", null, "503 You should say MAIL FROM
first\r\n");
+ INIT.init("RCPT TO:", ">=DATA", null, "503 You cannot use RCPT TO: at
this state\r\n");
}
SMTPSTATUS(int index) {
@@ -53,10 +53,10 @@
private void init(String command, String condition, SMTPSTATUS
targetStatus, String response) {
if (null == statusMap.get(command)) {
- statusMap.put(command, new HashMap<String,Action>());
+ statusMap.put(command, new HashMap<String, Action>());
}
- Map<String,Action> conditionMap = statusMap.get(command);
+ Map<String, Action> conditionMap = statusMap.get(command);
conditionMap.put(condition, new SMTPSTATUS.Action(targetStatus,
response));
@@ -64,7 +64,7 @@
public SMTPSTATUS.Action change(String command) {
- Map<String,Action> conditionMap = new HashMap<String,Action>();
+ Map<String, Action> conditionMap = new HashMap<String, Action>();
for (String key : statusMap.keySet()) {
if (command.startsWith(key)) {
Index: ReceiveThread.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/ReceiveThread.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- ReceiveThread.java 22 Sep 2008 07:53:42 -0000 1.3
+++ ReceiveThread.java 14 Oct 2008 11:22:44 -0000 1.4
@@ -28,8 +28,10 @@
private String[] params;
private SMTPSTATUS status = SMTPSTATUS.INIT;
+
public ReceiveThread() {
}
+
public ReceiveThread(Socket socket) {
this.socket = socket;
}
@@ -170,6 +172,7 @@
}
return isreading;
}
+
/**
* Interrupt method, is called only during shutdown
*/
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
