Update of
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services
In directory
james.mmbase.org:/tmp/cvs-serv7203/portlets-newsletter/src/java/com/finalist/newsletter/services
Modified Files:
Tag: b1_5
CommunityModuleAdapter.java StatisticService.java
Log Message:
CMSC-907 - Clean up code: convert to better methods; fix naming convention
violations; remove extra imports.
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: CommunityModuleAdapter.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/CommunityModuleAdapter.java,v
retrieving revision 1.14.2.1
retrieving revision 1.14.2.2
diff -u -b -r1.14.2.1 -r1.14.2.2
--- CommunityModuleAdapter.java 21 Oct 2008 07:25:05 -0000 1.14.2.1
+++ CommunityModuleAdapter.java 11 Feb 2009 09:08:29 -0000 1.14.2.2
@@ -75,7 +75,7 @@
public static String getUserNameByAuthenticationId(int authenticationId) {
AuthenticationService authenticationService = (AuthenticationService)
ApplicationContextFactory.getApplicationContext().getBean("authenticationService");
- com.finalist.cmsc.services.community.security.Authentication
authentication = authenticationService.getAuthenticationById(new
Long(authenticationId));
+ com.finalist.cmsc.services.community.security.Authentication
authentication =
authenticationService.getAuthenticationById(Long.valueOf(authenticationId));
if (authentication != null) {
return authentication.getUserId();
}
Index: StatisticService.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/StatisticService.java,v
retrieving revision 1.5
retrieving revision 1.5.2.1
diff -u -b -r1.5 -r1.5.2.1
--- StatisticService.java 23 Sep 2008 10:31:36 -0000 1.5
+++ StatisticService.java 11 Feb 2009 09:08:29 -0000 1.5.2.1
@@ -7,24 +7,24 @@
public interface StatisticService {
- public List<StatisticResult> statisticAll ();
+ public List<StatisticResult> statisticAll();
- public List<StatisticResult> statisticByNewsletter (int newsletterId);
+ public List<StatisticResult> statisticByNewsletter(int newsletterId);
- public List<StatisticResult> statisticAllByPeriod (String start, String end)
+ public List<StatisticResult> statisticAllByPeriod(String start, String end)
throws ServiceException;
- public StatisticResult statisticByNewsletterPeriod (int newsletterId,
+ public StatisticResult statisticByNewsletterPeriod(int newsletterId,
String start, String end) throws ServiceException;
- public StatisticResult statisticSummery ();
+ public StatisticResult statisticSummery();
- public StatisticResult statisticSummeryPeriod (String start, String end)
+ public StatisticResult statisticSummeryPeriod(String start, String end)
throws ServiceException;
- public StatisticResult StatisticSummaryByNewsletter (int newsletterId);
+ public StatisticResult statisticSummaryByNewsletter(int newsletterId);
- public List<StatisticResult> StatisticDetailByNewsletterPeriod (
+ public List<StatisticResult> statisticDetailByNewsletterPeriod(
int newsletterId, String start, String end) throws ServiceException;
public void logPubliction(int newsletterId, HANDLE handle);
@@ -32,4 +32,5 @@
public int pushSumedLogs(List<StatisticResult> listRecorder);
public List<StatisticResult> getLogs();
+
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
