Update of
/var/cvs/applications/taglib/src/org/mmbase/bridge/jsp/taglib/typehandler
In directory james.mmbase.org:/tmp/cvs-serv2533
Modified Files:
StringHandler.java
Log Message:
There is little point in making wider input areas than the field could contain
See also:
http://cvs.mmbase.org/viewcvs/applications/taglib/src/org/mmbase/bridge/jsp/taglib/typehandler
Index: StringHandler.java
===================================================================
RCS file:
/var/cvs/applications/taglib/src/org/mmbase/bridge/jsp/taglib/typehandler/StringHandler.java,v
retrieving revision 1.71
retrieving revision 1.72
diff -u -b -r1.71 -r1.72
--- StringHandler.java 3 Mar 2009 20:27:40 -0000 1.71
+++ StringHandler.java 7 Apr 2009 09:09:04 -0000 1.72
@@ -29,7 +29,7 @@
* @author Gerard van de Looi
* @author Michiel Meeuwissen
* @since MMBase-1.6
- * @version $Id: StringHandler.java,v 1.71 2009/03/03 20:27:40 michiel Exp $
+ * @version $Id: StringHandler.java,v 1.72 2009/04/07 09:09:04 michiel Exp $
*/
public class StringHandler extends AbstractTypeHandler {
@@ -43,6 +43,17 @@
super(tag);
}
+
+ /**
+ * @since MMBase-1.9.1
+ */
+ protected int getCols(Field field) {
+ int cols = field.getMaxLength();
+ if (cols > 80) cols = 80;
+ return cols;
+ }
+
+
/**
* @see TypeHandler#htmlInput(Node, Field, boolean)
*/
@@ -66,7 +77,7 @@
// wrap attribute removed, we want to produce valid
XHTML, and who is still using netscape < 6?
buffer.append("<textarea class=\"big " +
getClasses(node, field) + "\" rows=\"10\" cols=\"80\" ");
} else {
- buffer.append("<textarea class=\"small " +
getClasses(node, field) + "\" rows=\"5\" cols=\"80\" ");
+ buffer.append("<textarea class=\"small " +
getClasses(node, field) + "\" rows=\"5\" cols=\"" + getCols(field) + "\" ");
}
addExtraAttributes(buffer);
buffer.append("name=\"").append(prefix(field.getName())).append("\" ");
@@ -95,7 +106,7 @@
}
buffer.append("</textarea>");
} else { // not 'field' perhaps it's 'string'.
- buffer.append("<input class=\"small " + getClasses(node,
field) + "\" type=\"").append(dataType.isPassword() ? "password" :
"text").append("\" size=\"80\" ");
+ buffer.append("<input class=\"small " + getClasses(node,
field) + "\" type=\"").append(dataType.isPassword() ? "password" :
"text").append("\" size=\"" + getCols(field) + "\" ");
buffer.append("name=\"").append(prefix(field.getName())).append("\" ");
buffer.append("id=\"").append(prefixID(field.getName())).append("\" ");
String opt = tag.getOptions();
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
