[MMBASE SCM] r40800 - in CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter: publisher/bounce services services/impl

[jkoster]

Author: jkoster
Date: 2010-02-02 15:19:30 +0100 (Tue, 02 Feb 2010)
New Revision: 40800

Modified:
   
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/ReceiveThread.java
   
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/NewsletterService.java
   
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/impl/NewsletterServiceImpl.java
Log:
CMSC-1083 - Small code improvements.

Modified: 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/ReceiveThread.java
===================================================================
--- 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/ReceiveThread.java
   2010-02-02 14:19:22 UTC (rev 40799)
+++ 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/publisher/bounce/ReceiveThread.java
   2010-02-02 14:19:30 UTC (rev 40800)
@@ -115,7 +115,9 @@
          String username = recepient[0];
          if (username.startsWith("bounce-")) {
             params = username.replace("bounce-", "").split("=");
-            newsletterService.processBouncesOfPublication(params[0], 
params[1]);
+            int pId = Integer.parseInt(params[0]);
+            int uId = Integer.parseInt(params[1]);
+            newsletterService.processBouncesOfPublication(pId, uId);
          }
          writer.write("250 Yeah, OK. Bring on the data!\r\n");
          writer.flush();

Modified: 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/NewsletterService.java
===================================================================
--- 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/NewsletterService.java
       2010-02-02 14:19:22 UTC (rev 40799)
+++ 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/NewsletterService.java
       2010-02-02 14:19:30 UTC (rev 40800)
@@ -23,6 +23,6 @@
 
    public List<Newsletter> getNewsletters(String subscriber, String title, 
boolean paging);
 
-   void processBouncesOfPublication(String publicationId, String userId);
+   void processBouncesOfPublication(int publicationId, int userId);
 
 }

Modified: 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/impl/NewsletterServiceImpl.java
===================================================================
--- 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/impl/NewsletterServiceImpl.java
      2010-02-02 14:19:22 UTC (rev 40799)
+++ 
CMSContainer/trunk/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/impl/NewsletterServiceImpl.java
      2010-02-02 14:19:30 UTC (rev 40800)
@@ -92,20 +92,18 @@
       }
    }
 
-   public void processBouncesOfPublication(String publicationId, String 
userId) {
+   public void processBouncesOfPublication(int publicationId, int userId) {
       // todo test.
-      int pId = Integer.parseInt(publicationId);
-      int uId = Integer.parseInt(userId);
-      int newsletterId = publicationCAO.getNewsletterId(pId);
+      int newsletterId = publicationCAO.getNewsletterId(publicationId);
       Node newsletterNode = newsletterCAO.getNewsletterNodeById(newsletterId);
-      Node subscriptionNode = 
subscriptionCAO.getSubscriptionNode(newsletterId, uId);
+      Node subscriptionNode = 
subscriptionCAO.getSubscriptionNode(newsletterId, userId);
       int bouncesCount = subscriptionNode.getIntValue("count_bounces");
-      int maxAllowedBonce = newsletterNode.getIntValue("max_bounces");
+      int maxAllowedBounce = newsletterNode.getIntValue("max_bounces");
 
-      if (bouncesCount > maxAllowedBonce) {
+      if (bouncesCount > maxAllowedBounce) {
          subscriptionCAO.pause(subscriptionNode.getNumber());
       }
-      statisticCAO.logPublication(uId, newsletterId, 
StatisticResult.HANDLE.BOUNCE);
+      statisticCAO.logPublication(userId, newsletterId, 
StatisticResult.HANDLE.BOUNCE);
       subscriptionCAO.updateLastBounce(subscriptionNode.getNumber());
    }
 

_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs