Author: michiel
Date: 2010-03-02 11:56:10 +0100 (Tue, 02 Mar 2010)
New Revision: 41222
Modified:
mmbase/branches/MMBase-1_9/core/src/main/java/org/mmbase/bridge/implementation/BasicNodeManager.java
Log:
we have very many BasicNodeManagers, which we suspect to cause some performance
issues
Modified:
mmbase/branches/MMBase-1_9/core/src/main/java/org/mmbase/bridge/implementation/BasicNodeManager.java
===================================================================
---
mmbase/branches/MMBase-1_9/core/src/main/java/org/mmbase/bridge/implementation/BasicNodeManager.java
2010-03-02 09:21:40 UTC (rev 41221)
+++
mmbase/branches/MMBase-1_9/core/src/main/java/org/mmbase/bridge/implementation/BasicNodeManager.java
2010-03-02 10:56:10 UTC (rev 41222)
@@ -635,5 +635,16 @@
return new BasicRelationList(Collections.emptyList(), this);
}
+ @Override
+ protected void finalize() {
+ // http://www.fasterj.com/articles/finalizer1.shtml
+ // Having a non-empty finalizer can be quite expensive.
+ // BasicNodeManagers can exist very many (probably as virtual node
manager).
+ //
+ // Probably it is not actually correct to skip the finalize() of super,
+ // but I think only if the node is being edited, and commit or cancel
is not called.
+ // Which is for NodeManager quite unlikely.
+ }
+
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
