Author: michiel
Date: 2010-03-11 11:11:15 +0100 (Thu, 11 Mar 2010)
New Revision: 41324
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/GlobalError.java
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractNodeAction.java
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractRelationAction.java
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
Log:
details only
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/GlobalError.java
===================================================================
---
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/GlobalError.java
2010-03-11 02:59:49 UTC (rev 41323)
+++
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/GlobalError.java
2010-03-11 10:11:15 UTC (rev 41324)
@@ -6,7 +6,7 @@
The license (Mozilla version 1.0) can be read at the MMBase site.
See http://www.MMBase.org/license
-*/
+*/
package org.mmbase.applications.vprowizards.spring;
import java.util.Locale;
@@ -14,12 +14,17 @@
import org.apache.commons.lang.builder.ToStringBuilder;
+/**
+ * TODO. A GlobalError describes an exceptional situation. It should be an
Exception, and it should be thrown.
+ * Errors are obscured now by lack of stack-traces, and the code is littered
with try/catch-blocks.
+ */
+
public class GlobalError {
/**
* This is the type of error that is created when something went wrong,
and the transaction can not be committed in
* the end. A global error is a kind of error that will return an error
page, in stead of the referrer page.
- *
+ *
* @author Ernst Bunders
*/
private static ResourceBundle bundle = null;
@@ -38,7 +43,7 @@
/**
* Use this constructor if the message is a template that contains certain
placeholders to be replaced.
- *
+ *
* @param messageKey
* @param properties
*/
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractNodeAction.java
===================================================================
---
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractNodeAction.java
2010-03-11 02:59:49 UTC (rev 41323)
+++
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractNodeAction.java
2010-03-11 10:11:15 UTC (rev 41324)
@@ -31,6 +31,7 @@
* this is a template class for the 'real' node actions
* Is it more or less a redo of {...@link org.mmbase.datatypes.handler.html}
+ * @javadoc Why?
*
* @author ebunders
*
@@ -315,6 +316,8 @@
/**
* Creates a global error for this action.
+
+ * This is an example of exception reimplementation. This should all be
dropped and actual exceptions should be used.
*
* @param key
* @param placeholderValues
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractRelationAction.java
===================================================================
---
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractRelationAction.java
2010-03-11 02:59:49 UTC (rev 41323)
+++
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/AbstractRelationAction.java
2010-03-11 10:11:15 UTC (rev 41324)
@@ -22,6 +22,7 @@
import org.mmbase.util.logging.Logging;
/**
+ * @javadoc
* @author Ernst Bunders
*
*/
@@ -129,7 +130,7 @@
* @return true when source and destination nodes are found
*/
protected final boolean resolveSourceAndDestination(Transaction
transaction, Map<String, Node> idMap) {
- sourceNode = resolveNode("error.create.relation.nosource",
sourceNodeRef, sourceNodeNumber, idMap, transaction);
+ sourceNode = resolveNode("error.create.relation.nosource",
sourceNodeRef, sourceNodeNumber, idMap, transaction);
destinationNode = resolveNode("error.create.relation.nodestination",
destinationNodeRef, destinationNodeNumber,
idMap, transaction);
return (sourceNode != null && destinationNode != null);
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
===================================================================
---
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
2010-03-11 02:59:49 UTC (rev 41323)
+++
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
2010-03-11 10:11:15 UTC (rev 41324)
@@ -122,6 +122,7 @@
return Integer.valueOf(position);
} catch (RuntimeException e) {
+ // WTF Catching exceptions is evil.
addGlobalError("error.unexpected", new String[] { e.getMessage()
});
log.error("something went wrong running a query to find out the
position of a new relation. query: ["
+ q.toString() + "]", e);
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
