Author: michiel
Date: 2010-03-18 12:41:56 +0100 (Thu, 18 Mar 2010)
New Revision: 41502
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
Log:
premature catching of exceptions is not helpfull at all
Modified:
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
===================================================================
---
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
2010-03-18 10:59:06 UTC (rev 41501)
+++
mmbase/trunk/applications/vpro-wizards/src/main/java/org/mmbase/applications/vprowizards/spring/action/CreateRelationAction.java
2010-03-18 11:41:56 UTC (rev 41502)
@@ -114,34 +114,26 @@
int position = 1;
Query q = null;
- try {
- // find the lowest or highest relation number
+ // find the lowest or highest relation number
- // it is unlikely that the path matches duplicate builder names
here, but who knows?
- PathBuilder pathBuilder = new PathBuilder(new String[] {
sourceNode.getNodeManager().getName(),
- role,
-
destinationNode.getNodeManager().getName() });
- q = Queries.createQuery(transaction, sourceNode.getNumber() + "",
pathBuilder.getPath(),
- pathBuilder.getStep(1) + "." + sortField,
- null, pathBuilder.getStep(1) + "." +
sortField,
- (sortPosition.equals("begin") ? "up" :
"down"), null, false);
- q.setMaxNumber(1);
- NodeList nl = transaction.getList(q);
- if (nl.size() > 0) {
- position = nl.getNode(0).getIntValue(role + "." + sortField);
- position = (sortPosition.equals("begin") ? position - 1 :
position + 1);
- } else {
- log.warn("Query " + q + " didn't result anything");
- }
-
- return Integer.valueOf(position);
- } catch (RuntimeException e) {
- // WTF Catching exceptions is evil.
- addGlobalError("error.unexpected", new String[] { e.getMessage()
});
- log.error("something went wrong running a query to find out the
position of a new relation. query: ["
- + q.toString() + "]", e);
+ // it is unlikely that the path matches duplicate builder names here,
but who knows?
+ PathBuilder pathBuilder = new PathBuilder(new String[] {
sourceNode.getNodeManager().getName(),
+ role,
+
destinationNode.getNodeManager().getName() });
+ q = Queries.createQuery(transaction, sourceNode.getNumber() + "",
pathBuilder.getPath(),
+ pathBuilder.getStep(1) + "." + sortField,
+ null, pathBuilder.getStep(1) + "." + sortField,
+ (sortPosition.equals("begin") ? "up" :
"down"), null, false);
+ q.setMaxNumber(1);
+ NodeList nl = transaction.getList(q);
+ if (nl.size() > 0) {
+ position = nl.getNode(0).getIntValue(role + "." + sortField);
+ position = (sortPosition.equals("begin") ? position - 1 : position
+ 1);
+ } else {
+ log.warn("Query " + q + " didn't result anything");
}
- return null;
+
+ return Integer.valueOf(position);
}
public String getSortPosition() {
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
