[MMBASE SCM] r41923 - mmbase/trunk/bridge/src/main/java/org/mmbase/security

[michiel]

Author: michiel
Date: 2010-04-13 19:27:15 +0200 (Tue, 13 Apr 2010)
New Revision: 41923

Modified:
   mmbase/trunk/bridge/src/main/java/org/mmbase/security/BasicUser.java
Log:
dropped a few constructors, which made it possible to have instances of this 
without an authenticaiotn member, which is bad

Modified: mmbase/trunk/bridge/src/main/java/org/mmbase/security/BasicUser.java
===================================================================
--- mmbase/trunk/bridge/src/main/java/org/mmbase/security/BasicUser.java        
2010-04-13 17:16:51 UTC (rev 41922)
+++ mmbase/trunk/bridge/src/main/java/org/mmbase/security/BasicUser.java        
2010-04-13 17:27:15 UTC (rev 41923)
@@ -33,12 +33,6 @@
     private final String identifier;
     protected final Authentication authentication;
 
-    public BasicUser(String authenticationType) {
-        this(authenticationType, "anonymous");
-    }
-    public BasicUser(String authenticationType, String identifier) {
-        this(null, authenticationType, identifier);
-    }
     public BasicUser(Authentication auth, String authenticationType, String 
identifier) {
         this.authenticationType = authenticationType;
         this.identifier = identifier;
@@ -89,9 +83,12 @@
 
     public boolean isValid() {
         try {
-            return authentication != null ?
-                authentication.isValid(this) :
-                false; // TODO? 
org.mmbase.module.core.MMBase.getMMBase().getMMBaseCop().getAuthentication().isValid(this);
+            if (authentication == null) {
+                log.warn("No authentication object in " + this);
+                return false;
+            } else {
+                return authentication.isValid(this);
+            }
         } catch (Exception e) {
             log.warn(e);
             return false;

_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs