shuber 2005/03/31 19:47:17 CEST
Modified files:
core/src/java/org/jahia/services/usermanager JahiaDBUser.java
JahiaLDAPUser.java
JahiaUserManagerDBProvider.java
Log:
Fix NPE when creating new site.
Revision Changes Path
1.5 +28 -13
jahia/core/src/java/org/jahia/services/usermanager/JahiaDBUser.java
http://jahia.mine.nu:8080/cgi-bin/cvsweb.cgi/jahia/core/src/java/org/jahia/services/usermanager/JahiaDBUser.java.diff?r1=1.4&r2=1.5&f=h
1.7 +26 -13
jahia/core/src/java/org/jahia/services/usermanager/JahiaLDAPUser.java
http://jahia.mine.nu:8080/cgi-bin/cvsweb.cgi/jahia/core/src/java/org/jahia/services/usermanager/JahiaLDAPUser.java.diff?r1=1.6&r2=1.7&f=h
1.7 +7 -2
jahia/core/src/java/org/jahia/services/usermanager/JahiaUserManagerDBProvider.java
http://jahia.mine.nu:8080/cgi-bin/cvsweb.cgi/jahia/core/src/java/org/jahia/services/usermanager/JahiaUserManagerDBProvider.java.diff?r1=1.6&r2=1.7&f=h
Index: JahiaDBUser.java
===================================================================
RCS file:
/home/cvs/repository/jahia/core/src/java/org/jahia/services/usermanager/JahiaDBUser.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JahiaDBUser.java 24 Mar 2005 16:28:13 -0000 1.4
+++ JahiaDBUser.java 31 Mar 2005 17:47:17 -0000 1.5
@@ -215,7 +215,11 @@
* only modifications through setProperty() are supported and serialized.
*/
public Properties getProperties () {
- return mProperties.getProperties();
+ if (mProperties != null) {
+ return mProperties.getProperties();
+ } else {
+ return null;
+ }
}
/**
@@ -276,6 +280,10 @@
public synchronized boolean removeProperty (String key) {
boolean result = false;
+ if (mProperties == null) {
+ return result;
+ }
+
if ((key != null) && (key.length () > 0) &&
(!mProperties.isReadOnly(key))) {
JahiaUserDBUtils utils = JahiaUserDBUtils.getInstance ();
if (utils != null) {
@@ -378,6 +386,10 @@
public synchronized boolean setProperty (String key, String value) {
boolean result = false;
+ if (mProperties == null) {
+ return result;
+ }
+
if ((key != null) && (value != null) &&
(!mProperties.isReadOnly(key))) {
JahiaUserDBUtils utils = JahiaUserDBUtils.getInstance ();
@@ -449,21 +461,24 @@
StringBuffer output = new StringBuffer ("Detail of user [" +
mUsername + "]\n");
output.append (" - ID [" + Integer.toString (mID) + "]");
output.append (" - password [" + mPassword + "]\n");
- output.append (" - properties :");
- Iterator nameIter = mProperties.propertyNameIterator();
- String name;
- if (nameIter.hasNext ()) {
- output.append ("\n");
- while (nameIter.hasNext ()) {
- name = (String) nameIter.next ();
- output.append (
- " " + name + " -> [" + (String)
mProperties.getProperty (name) + "]\n");
+ if (mProperties != null) {
+ output.append(" - properties :");
+
+ Iterator nameIter = mProperties.propertyNameIterator();
+ String name;
+ if (nameIter.hasNext()) {
+ output.append("\n");
+ while (nameIter.hasNext()) {
+ name = (String) nameIter.next();
+ output.append(
+ " " + name + " -> [" +
+ (String) mProperties.getProperty(name) + "]\n");
+ }
+ } else {
+ output.append(" -no properties-\n");
}
- } else {
- output.append (" -no properties-\n");
}
-
return output.toString ();
}
Index: JahiaLDAPUser.java
===================================================================
RCS file:
/home/cvs/repository/jahia/core/src/java/org/jahia/services/usermanager/JahiaLDAPUser.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- JahiaLDAPUser.java 24 Mar 2005 16:28:13 -0000 1.6
+++ JahiaLDAPUser.java 31 Mar 2005 17:47:17 -0000 1.7
@@ -160,7 +160,11 @@
* only modifications through setProperty() are supported and serialized.
*/
public Properties getProperties () {
- return mProperties.getProperties();
+ if (mProperties != null) {
+ return mProperties.getProperties();
+ } else {
+ return null;
+ }
}
/**
@@ -212,6 +216,9 @@
*/
public synchronized boolean removeProperty (String key) {
boolean result = false;
+ if (mProperties == null) {
+ return result;
+ }
if ((key != null) && (key.length () > 0) &&
(!mProperties.isReadOnly(key))) {
// Remove these lines if LDAP problem --------------------
@@ -283,6 +290,9 @@
*/
public synchronized boolean setProperty (String key, String value) {
boolean result = false;
+ if (mProperties == null) {
+ return result;
+ }
if ((key != null) && (value != null) &&
(!mProperties.isReadOnly(key))) {
// Remove these lines if LDAP problem --------------------
@@ -399,21 +409,24 @@
StringBuffer output = new StringBuffer ("Detail of user [" +
mUsername + "]\n");
output.append (" - ID [" + Integer.toString (mID) + "]");
output.append (" - password [" + mPassword + "]\n");
- output.append (" - properties :");
- Iterator nameIter = mProperties.propertyNameIterator ();
- String name;
- if (nameIter.hasNext()) {
- output.append ("\n");
- while (nameIter.hasNext()) {
- name = (String) nameIter.next();
- output.append (
- " " + name + " -> [" + (String)
mProperties.getProperty (name) + "]\n");
+ if (mProperties != null) {
+ output.append(" - properties :");
+
+ Iterator nameIter = mProperties.propertyNameIterator();
+ String name;
+ if (nameIter.hasNext()) {
+ output.append("\n");
+ while (nameIter.hasNext()) {
+ name = (String) nameIter.next();
+ output.append(
+ " " + name + " -> [" +
+ (String) mProperties.getProperty(name) + "]\n");
+ }
+ } else {
+ output.append(" -no properties-\n");
}
- } else {
- output.append (" -no properties-\n");
}
-
return output.toString ();
}
Index: JahiaUserManagerDBProvider.java
===================================================================
RCS file:
/home/cvs/repository/jahia/core/src/java/org/jahia/services/usermanager/JahiaUserManagerDBProvider.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- JahiaUserManagerDBProvider.java 24 Mar 2005 16:28:13 -0000 1.6
+++ JahiaUserManagerDBProvider.java 31 Mar 2005 17:47:17 -0000 1.7
@@ -158,8 +158,13 @@
// Create the user
JahiaDBUser user = null;
- user = new JahiaDBUser (userID, name, password, userKey, siteID, new
UserProperties(properties, false));
-
+ if (properties != null) {
+ user = new JahiaDBUser(userID, name, password, userKey, siteID,
+ new UserProperties(properties, false));
+ } else {
+ user = new JahiaDBUser(userID, name, password, userKey, siteID,
+ null);
+ }
// add the user into the cache if the user could be added into the
database.
if (addUserIntoDB (userID, name, password, userKey, siteID,
properties)) {
mUserCache.put ("k"+user.getName(), user);
