cvs commit: jahia/core/src/java/org/jahia/params ParamBean.java

[Serge Huber]

shuber      2005/11/09 11:57:20 CET

  Modified files:
    core/src/java/org/jahia/params ParamBean.java 
  Log:
  - Added code to ignore invalid field, container and container list id since 
it seems the Googlebot generates these errors
  
  Revision  Changes    Path
  1.41      +24 -9     jahia/core/src/java/org/jahia/params/ParamBean.java
http://jahia.mine.nu:8080/cgi-bin/cvsweb.cgi/jahia/core/src/java/org/jahia/params/ParamBean.java.diff?r1=1.40&r2=1.41&f=h
  
  
  
  Index: ParamBean.java
  ===================================================================
  RCS file: 
/home/cvs/repository/jahia/core/src/java/org/jahia/params/ParamBean.java,v
  retrieving revision 1.40
  retrieving revision 1.41
  diff -u -r1.40 -r1.41
  --- ParamBean.java    9 Nov 2005 10:16:47 -0000       1.40
  +++ ParamBean.java    9 Nov 2005 10:57:20 -0000       1.41
  @@ -410,19 +410,34 @@
               if (site != null) {
   
                   // Get the field ID information
  -                if (getParameter(FIELD_ID_PARAMETER) != null) {
  -                    this.fieldID = Integer.parseInt(getParameter(
  -                        FIELD_ID_PARAMETER));
  +                String fieldIDStr = getParameter(FIELD_ID_PARAMETER);
  +                if (fieldIDStr != null) {
  +                    try {
  +                        this.setFieldID(Integer.parseInt(fieldIDStr));
  +                    } catch (NumberFormatException nfe) {
  +                        logger.warn("Invalid field ID ["+fieldIDStr+"] in 
request, ignoring...");
  +                        this.setFieldID(0);
  +                    }
                   }
   
  -                if (getParameter(CONTAINER_ID_PARAMETER) != null) {
  -                    this.containerID = Integer.parseInt(getParameter(
  -                        CONTAINER_ID_PARAMETER));
  +                String containerIDStr = getParameter(CONTAINER_ID_PARAMETER);
  +                if (containerIDStr != null) {
  +                    try {
  +                        
this.setContainerID(Integer.parseInt(containerIDStr));
  +                    } catch (NumberFormatException nfe) {
  +                        logger.warn("Invalid container ID 
["+containerIDStr+"] in request, ignoring...");
  +                        this.setContainerID(0);
  +                    }
                   }
   
  -                if (getParameter(CONTAINERLIST_ID_PARAMETER) != null) {
  -                    this.containerListID = Integer.parseInt(getParameter(
  -                        CONTAINERLIST_ID_PARAMETER));
  +                String containerListIDStr = 
getParameter(CONTAINERLIST_ID_PARAMETER);
  +                if (containerListIDStr != null) {
  +                    try {
  +                    
this.setContainerListID(Integer.parseInt(containerListIDStr));
  +                    } catch (NumberFormatException nfe) {
  +                        logger.warn("Invalid container list ID 
["+containerListIDStr+"] in request, ignoring...");
  +                        this.setContainerListID(0);
  +                    }
                   }
   
                   int pageID = -1;