Author: tdraier
Date: Fri Aug 4 12:03:11 2006
New Revision: 14843
URL: https://svndev.jahia.net/websvn/listing.php?sc=1&rev=14843&repname=jahia
Log:
simpler and thread safe implementation
Modified:
trunk/core/src/java/org/jahia/engines/shared/BigText_Field.java
Modified: trunk/core/src/java/org/jahia/engines/shared/BigText_Field.java
URL:
https://svndev.jahia.net/websvn/diff.php?path=/trunk/core/src/java/org/jahia/engines/shared/BigText_Field.java&rev=14843&repname=jahia
==============================================================================
--- trunk/core/src/java/org/jahia/engines/shared/BigText_Field.java (original)
+++ trunk/core/src/java/org/jahia/engines/shared/BigText_Field.java Fri Aug 4
12:03:11 2006
@@ -24,6 +24,7 @@
package org.jahia.engines.shared;
+import org.apache.commons.lang.StringUtils;
import org.jahia.content.ContentFieldKey;
import org.jahia.content.ContentPageKey;
import org.jahia.content.ObjectLink;
@@ -51,7 +52,6 @@
import org.jahia.services.version.EntryLoadRequest;
import org.jahia.utils.I18n;
import org.jahia.utils.JahiaTools;
-import org.apache.commons.lang.StringUtils;
import java.util.*;
@@ -72,7 +72,6 @@
public static final String HTMLEDITOR_VIEW_HELPER_ATTRIBUTE =
"org.jahia.engines.shared.BigText_Field.HTMLEditorsViewHelper";
- protected final StringBuffer buff;
private boolean ignoreAllWarnings = false;
/**
@@ -84,7 +83,6 @@
// Don't let anyone instantiate this class
private BigText_Field() {
- buff = new StringBuffer();
}
/**
@@ -101,10 +99,7 @@
final int mode = modeInt.intValue();
final String fieldsEditCallingEngineName = (String) engineMap.get(
"fieldsEditCallingEngineName" );
- final JahiaField theField = (JahiaField) engineMap.get(
- buff.append(fieldsEditCallingEngineName).append(".theField").
- toString() );
- buff.delete(0, buff.length());
+ final JahiaField theField = (JahiaField)
engineMap.get(fieldsEditCallingEngineName+".theField");
initHtmlEditorsHelpers(engineMap, jParams);
String value = theField.getValue();
@@ -155,11 +150,8 @@
Boolean.valueOf(ignoreAllWarnings));
boolean out = true;
- String fieldValue = jParams.getParameter(
- buff.append("_").append(theField.getID()).toString());
- buff.delete(0, buff.length());
-
- logger.debug("GetFormData: theField.getValue(): "+ theField.getValue()
+
+ String fieldValue = jParams.getParameter("_"+theField.getID());
+ logger.debug("GetFormData: theField.getValue(): "+ theField.getValue()
+
", fieldValue: " + fieldValue);
final JahiaSite site = ServicesRegistry.getInstance().
@@ -196,11 +188,8 @@
final EngineMessages resultMessages =
ServicesRegistry.getInstance().
getHtmlParserService().checkTextParsingErrors(fieldValue);
if ( !resultMessages.isEmpty() ) {
- resultMessages.saveMessages(
- buff.append(theField.getID()).append(".").toString(),
- ((ParamBean)jParams).getRequest());
- buff.delete(0, buff.length());
-
+
resultMessages.saveMessages(theField.getID()+".",((ParamBean)jParams).getRequest());
+
fieldValue = oriFieldValue;
out = false;
}
@@ -239,10 +228,7 @@
engineMap, theField, false);
if (! warningMessages.isEmpty()) {
- warningMessages.saveMessages(
-
buff.append(theField.getID()).append(".warning.").toString(),
- ((ParamBean)jParams).getRequest());
- buff.delete(0, buff.length());
+
warningMessages.saveMessages(theField.getID()+".warning.",((ParamBean)jParams).getRequest());
logger.debug("There are some Integrity warning messages
!");
out = false;
@@ -257,10 +243,7 @@
final EngineMessages warningMessages = toEngineMessages(evh);
if ( ! warningMessages.isEmpty() ) {
- warningMessages.saveMessages(
-
buff.append(theField.getID()).append(".WAIwarning.").toString(),
- ((ParamBean)jParams).getRequest());
- buff.delete(0, buff.length());
+
warningMessages.saveMessages(theField.getID()+".WAIwarning.",((ParamBean)jParams).getRequest());
logger.debug("There are some WAI warning messages !");
return false;
@@ -471,19 +454,14 @@
final String fieldsEditCallingEngineName = (String) engineMap.get(
"fieldsEditCallingEngineName" );
boolean editable = false;
- final JahiaContainer theContainer = (JahiaContainer)engineMap.get(
- buff.append(fieldsEditCallingEngineName).
- append(".theContainer").toString());
- buff.delete(0, buff.length());
+ final JahiaContainer theContainer =
(JahiaContainer)engineMap.get(fieldsEditCallingEngineName + (".theContainer"));
int fieldId = theField.getID();
if (theContainer == null) {
// in case of a field , not a field in a container
editable = true;
} else {
final FieldsEditHelper feh = (FieldsEditHelper)engineMap.get(
- buff.append(fieldsEditCallingEngineName).append(".").
-
append(FieldsEditHelperAbstract.FIELDS_EDIT_HELPER_CONTEXTID).toString());
- buff.delete(0, buff.length());
+
fieldsEditCallingEngineName+"."+FieldsEditHelperAbstract.FIELDS_EDIT_HELPER_CONTEXTID);
HashMap ctnListFieldAcls = feh.getCtnListFieldAcls();
if (theContainer.getListID() != 0 && ctnListFieldAcls != null &&
ctnListFieldAcls.size()>0) {
JahiaBaseACL acl =
JahiaEngineTools.getCtnListFieldACL(ctnListFieldAcls, fieldId);
@@ -550,10 +528,8 @@
output = ServicesRegistry.getInstance().getJahiaFetcherService().
fetchServlet( (ParamBean) jParams, forward );
}
- engineMap.put(buff.append(fieldsEditCallingEngineName).
- append(".fieldForm").toString(), output );
- buff.delete(0, buff.length());
-
+ engineMap.put(fieldsEditCallingEngineName+".fieldForm", output );
+
return true;
} // end composeEngineMap
@@ -660,6 +636,7 @@
jParams, engineMap);
final Iterator ite = c.iterator();
+ StringBuffer buff = new StringBuffer();
while (ite.hasNext()) {
final String groupID = (String)ite.next();
buff.append(groupID).append(",");
@@ -670,7 +647,6 @@
}
final String result = buff.toString();
- buff.delete(0, buff.length());
return result;
}
