Author: ktlili
Date: Wed Oct 17 12:29:14 2007
New Revision: 18892
URL: https://svndev.jahia.net/websvn/listing.php?sc=3D1&rev=3D18892&repname=
=3Djahia
Log:
- mem. leak : un-references javascript var when no longer used
Modified:
branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript/engin=
es.js
branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript/worki=
nprogress.js
Modified: branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript=
/engines.js
URL: https://svndev.jahia.net/websvn/diff.php?path=3D/branches/JAHIA-5-0-SP=
-BRANCH/core/src/webapp/jsp/jahia/javascript/engines.js&rev=3D18892&repname=
=3Djahia
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript/engin=
es.js (original)
+++ branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript/engin=
es.js Wed Oct 17 12:29:14 2007
@@ -157,6 +157,7 @@
CloseJahiaWindow();
}
}
+
}
=
// resize pageBody
@@ -183,6 +184,11 @@
if (newHeight > pageBodyEleHeight) {
pageBodyEle.style.height =3D (myHeight - 130) + "px";
}
+
+ // unreference var
+ myWidth =3D null;
+ myHeight =3D null;
+ pageBodyEle =3D null;
}
=
function handleOnLoad() {
Modified: branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript=
/workinprogress.js
URL: https://svndev.jahia.net/websvn/diff.php?path=3D/branches/JAHIA-5-0-SP=
-BRANCH/core/src/webapp/jsp/jahia/javascript/workinprogress.js&rev=3D18892&=
repname=3Djahia
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript/worki=
nprogress.js (original)
+++ branches/JAHIA-5-0-SP-BRANCH/core/src/webapp/jsp/jahia/javascript/worki=
nprogress.js Wed Oct 17 12:29:14 2007
@@ -39,13 +39,14 @@
imgLoading.alt =3D 'Loading...';
imgLoading.title =3D 'Loading...';
$('workInProgressOverlay').appendChild(imgLoading);
+ imgLoading =3D null;
}
$('workInProgressOverlay').style.display =3D 'block';
},
=
_createMarkup: function() {
- bod =3D document.getElementsByTagName('body')[0];
- overlay =3D document.createElement('div');
+ var bod =3D document.getElementsByTagName('body')[0];
+ var overlay =3D document.createElement('div');
overlay.id =3D 'workInProgressOverlay';
if (!this.isIE){
var imgLoading =3D document.createElement('img');
@@ -53,17 +54,26 @@
imgLoading.alt =3D 'Loading...';
imgLoading.title =3D 'Loading...';
overlay.appendChild(imgLoading);
+ imgLoading =3D null;
}
bod.appendChild(overlay);
+
+ // avoid mem leak
+ bod =3D null;
+ overlay =3D null;
},
=
_prepareIE: function(height, overflow) {
- bod =3D document.getElementsByTagName('body')[0];
+ var bod =3D document.getElementsByTagName('body')[0];
bod.style.height =3D height;
bod.style.overflow =3D overflow;
=
- htm =3D document.getElementsByTagName('html')[0];
+ var htm =3D document.getElementsByTagName('html')[0];
htm.style.height =3D height;
- htm.style.overflow =3D overflow; =
+ htm.style.overflow =3D overflow;
+
+ // avoid mem leak
+ bod =3D null;
+ htm =3D null;
}
}
\ No newline at end of file
_______________________________________________
cvs_list mailing list
[email protected]
http://lists.jahia.org/cgi-bin/mailman/listinfo/cvs_list
