Author: dkulp Date: Thu Nov 1 11:48:22 2007 New Revision: 591117 URL: http://svn.apache.org/viewvc?rev=591117&view=rev Log: [CXF-1158, CXF-1146] Add ability to turn off address rewriting in servlet Fix issues with validator not being able to determine if op is rpc or doc Fix distribution of wrong commons logging jars
Modified: incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpers/WSDLHelper.java incubator/cxf/trunk/distribution/pom.xml incubator/cxf/trunk/parent/pom.xml incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstService.java incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java Modified: incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpers/WSDLHelper.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpers/WSDLHelper.java?rev=591117&r1=591116&r2=591117&view=diff ============================================================================== --- incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpers/WSDLHelper.java (original) +++ incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpers/WSDLHelper.java Thu Nov 1 11:48:22 2007 @@ -170,7 +170,7 @@ Binding binding = (Binding)ite.next(); for (Iterator ite2 = binding.getBindingOperations().iterator(); ite2.hasNext();) { BindingOperation bindingOperation = (BindingOperation)ite2.next(); - if (bindingOperation.getName().equals(bop)) { + if (bindingOperation.getName().equals(bop.getName())) { return binding; } } Modified: incubator/cxf/trunk/distribution/pom.xml URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/pom.xml?rev=591117&r1=591116&r2=591117&view=diff ============================================================================== --- incubator/cxf/trunk/distribution/pom.xml (original) +++ incubator/cxf/trunk/distribution/pom.xml Thu Nov 1 11:48:22 2007 @@ -83,13 +83,13 @@ <artifactId>cxf-tools-wsdlto-frontend-jaxws</artifactId> <version>${pom.version}</version> </dependency> - + <dependency> <groupId>${pom.groupId}</groupId> <artifactId>cxf-tools-java2ws</artifactId> <version>${pom.version}</version> - </dependency> - + </dependency> + <dependency> <groupId>${pom.groupId}</groupId> <artifactId>cxf-xjc-dv</artifactId> @@ -177,7 +177,7 @@ <artifactId>cxf-rt-databinding-aegis</artifactId> <version>${pom.version}</version> </dependency> - + <dependency> <groupId>${pom.groupId}</groupId> <artifactId>cxf-rt-ws-addr</artifactId> @@ -193,7 +193,7 @@ <artifactId>cxf-rt-ws-policy</artifactId> <version>${pom.version}</version> </dependency> - <dependency> + <dependency> <groupId>${pom.groupId}</groupId> <artifactId>cxf-rt-ws-security</artifactId> <version>${pom.version}</version> @@ -240,9 +240,12 @@ <version>${pom.version}</version> </dependency> <dependency> - <groupId>commons-httpclient</groupId> - <artifactId>commons-httpclient</artifactId> - <version>3.1-rc1</version> + <groupId>commons-httpclient</groupId> + <artifactId>commons-httpclient</artifactId> + </dependency> + <dependency> + <groupId>commons-logging</groupId> + <artifactId>commons-logging</artifactId> </dependency> </dependencies> @@ -396,7 +399,7 @@ <scm> <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/cxf/trunk/distribution</connection> <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/cxf/trunk/distribution</developerConnection> - <url>http://svn.apache.org/viewvc/incubator/cxf/trunk/cxf-parent/cxf-distribution</url> - </scm> + <url>http://svn.apache.org/viewvc/incubator/cxf/trunk/cxf-parent/cxf-distribution</url> + </scm> </project> Modified: incubator/cxf/trunk/parent/pom.xml URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/parent/pom.xml?rev=591117&r1=591116&r2=591117&view=diff ============================================================================== --- incubator/cxf/trunk/parent/pom.xml (original) +++ incubator/cxf/trunk/parent/pom.xml Thu Nov 1 11:48:22 2007 @@ -597,6 +597,11 @@ </exclusions> </dependency> <dependency> + <groupId>commons-httpclient</groupId> + <artifactId>commons-httpclient</artifactId> + <version>3.1</version> + </dependency> + <dependency> <groupId>commons-logging</groupId> <artifactId>commons-logging</artifactId> <version>1.1</version> Modified: incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstService.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstService.java?rev=591117&r1=591116&r2=591117&view=diff ============================================================================== --- incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstService.java (original) +++ incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstService.java Thu Nov 1 11:48:22 2007 @@ -81,7 +81,7 @@ List<Foo[]> listObjectArrayOutput(); @WebMethod - int throwException(int i) throws ServiceTestFault; + int throwException(int i) throws ServiceTestFault, CustomException; @RequestWrapper(localName = "echoIntX") @ResponseWrapper(localName = "echoIntXResponse") Modified: incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java?rev=591117&r1=591116&r2=591117&view=diff ============================================================================== --- incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java (original) +++ incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java Thu Nov 1 11:48:22 2007 @@ -118,11 +118,15 @@ return Arrays.asList(new Foo[] {a, b}, new Foo[] {c, d}); } - public int throwException(int i) throws ServiceTestFault { - if (i == -1) { + public int throwException(int i) throws ServiceTestFault, CustomException { + switch (i) { + case -1: throw new ServiceTestFault("Hello!"); + case -2: + throw new CustomException("CE: " + i); + default: + throw new ServiceTestFault(new ServiceTestFault.ServiceTestDetails(i)); } - throw new ServiceTestFault(new ServiceTestFault.ServiceTestDetails(i)); } public String echo(String msg) { Modified: incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java?rev=591117&r1=591116&r2=591117&view=diff ============================================================================== --- incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java (original) +++ incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java Thu Nov 1 11:48:22 2007 @@ -248,9 +248,9 @@ BindingOperation bop = wsdlHelper.getBindingOperation(def, operation.getName()); Binding binding = wsdlHelper.getBinding(bop, def); String bindingStyle = binding != null ? SOAPBindingUtil.getBindingStyle(binding) : ""; - String style = "".equals(SOAPBindingUtil.getSOAPOperationStyle(bop)) + String style = StringUtils.isEmpty(SOAPBindingUtil.getSOAPOperationStyle(bop)) ? bindingStyle : SOAPBindingUtil.getSOAPOperationStyle(bop); - if ("DOCUMENT".equalsIgnoreCase(style) || "".equals(style)) { + if ("DOCUMENT".equalsIgnoreCase(style) || StringUtils.isEmpty(style)) { boolean passed = checkR2201Input(operation, bop) && checkR2201Output(operation, bop) && checkR2716(bop); @@ -258,6 +258,7 @@ return false; } } else { + System.out.println("Style: " + style); if (!checkR2717AndR2726(bop)) { return false; }