Hi James,
I see, and I don't really care where the stuff lives - although I don't
like the idea of turning common into some general purpose container for
stuff that could be needed anywhere ...
If you don't like the xjc plugins living in the tools module another
option would be to restructure codegen-plugin into
codegen
/xjc/dev
/xjc/cxf
/maven-plugins/xsd2java
/maven-plugins/wsdl2java
Andrea.
James Mao wrote:
Hi Andrea,
Well it's not the xjc plugins in tools, it's the xsd code gen plugin.
I'm thinking of moving the xsd code gen plugin into the common, since
they are all xjc stuff, so i'm thinking of moving those xjc plugins
together, but not required though.
So here's my plan,
common/utilities (previous common module)
/xsd (xsd code gen plugin)
/metacode (using xsd code gen to generate code from xsd files)
/xjc/dv (optional)
/cxf (optional)
So it requires moving xsd files into common/metacode, and also a java
class org.apache.cxf.wsdl.TExtensibilityElementImpl
I've already pass build on my machine. if there are no objections, i'm
going to commit tomorrow. and after that Tom will go on refactoring
tools.
Cheers,
James.
Andrea Smyth 写道:
James Mao wrote:
Hi,
I'm thinking of moving the xjc plugins into common module.
I just read the pom.xml in xjc plugins seems there are no
relationship with tools
No, there is no dependency on other tools modules, only on cxf-common
and third party stuff. The reason these plugins are in tools is that
they are, well, tools.
The benefit of xjc plugins in the common module is that the tools
can also use xjc to generate the code.
Any objections?
No objections, but I don't see the need. What code is generated in
tools, and which part of the code generation requires these xjc plugins?
Andrea.
Cheers,
James.
