Hi Eoghan,
I take your suggestion and will try my best to keep the HTTP module's
SVN history.
Willem.
Glynn, Eoghan wrote:
Willem,
Instead of doing a straight swap, I would recommend re-applying the
Jetty5->Jetty6 API changes manually to the http code, and then deleting
the http2 version.
That way we'd get to keep the SVN history of the original HTTP code, and
also be 100% sure that we've lost none of the mods made to the http
module since the http2 fork (most of these mods were manually reflected
in the http2 module, but not all).
/Eoghan
-----Original Message-----
From: Willem Jiang [mailto:[EMAIL PROTECTED]
Sent: 13 March 2007 03:40
To: [email protected]
Subject: Re: HTTP2 [was Re: Accessing Connection-based info
from the transport]
Hi
I just ran the systest by replacing the HTTP module with
HTTP2 module.
The MAPTest and NonDecoupledTest all passed.
I don't know if someone had fixed them, or it is related to
move the test to JUnit4.
Anyway we can move on to HTTP2.
I will commit a change of pom to use the HTTP2 instead of
HTTP and build a kit test of it.
If there is not any objection of replacing HTTP with HTTP2,
I will remove HTTP and switch HTTP2 module to HTTP in the
next couple days.
Cheers,
Willem
Dan Diephouse wrote:
On 3/12/07, Glynn, Eoghan <[EMAIL PROTECTED]> wrote:
BTW you're preaching to the converted on the issue of the
duplication
across http and http2. I've been moaning on this list about the
obvious maintenance issues since this was first committed,
and I've
suggested several times that it be removed from the mainline to a
branch. I just noticed that this issue has been made even worse
recently, when the servlet transport was decoupled from the JAX-WS
module (a good thing in itself), but then duplicated to
both http and http2 ... Arghhh!
AFAIK we have one issue outstanding with WS-A and HTTP2
yet. Did you
or anyone else get a chance to look at it?
I say we delete http now and switch to http2. We can then fix the
broken test or two over the next couple days. This is
causing too much
pain for it to continue IMO.
- Dan
