> -----Original Message-----
> From: Dan Diephouse [mailto:[EMAIL PROTECTED]
> Sent: 24 April 2007 17:41
> To: [email protected]
> Subject: Re: <jaxws:client> createdFromAPI attribute
>
> Hiya,
>
> In one of my previous commit messages I detailed this change
> and why it needed to be done. In essence if you have a
> <jaxws:client> and a <jaxws:endpoint> with the same id, they
> conflict. In essence there were two solutions.
>
> 1. Change the bean definitions parsers to automatically
> append ".jaxws-client" and ".jaxws-endpoint" to the bean
> names 2. Force people to append those to the ID themselves.
We discussed this previously on the list and I thought the conclusion
was to go with the ".jaxws-client/endpoint" suffices, so as to be
consistent with the HTTP config bean names.
I'm not too hung up on either approach (suffix or createFromAPI attr),
but I think it really does need to be consistent ... i.e. either all
beans change over to createFromAPI, or all go with the suffix, but not a
mixture of approaches (which would be a recipe for user confusion).
> As appending .jaxws-client to each ID seemed rather
> redundant, I opted for choice #1. From here there were two choices:
> 1. Automatically change the id if abstract=true 2. Create
> some other mechanism to automatically change the id - i.e.
> createdFromAPI = true
>
> If we went with #1 this would break parent/child
> relationships for the normal spring case ("why isn't my ID
> what I specified it to be?!?!"). So I opted for solution #2.
>
> createdFromAPI simply means that the user created that bean
> using our APIs - i.e. Endpoint.publish or Service.getPort. If
> you have better suggestions, I would welcome them - I asked
> for some in my commit message.
>
> I updated all the tests to use createdFromAPI and also all
> the demos. the coloc demo was added after these changes, so I
> did not review that one.
Well the coloc system test definitely pre-dated your merge, and then the
recently added coloc demo simply cloned the un-updated config from the
system test.
But no matter, it's a trivial change, which I'll commit now.
/Eoghan
> - Dan
>
> On 4/24/07, Glynn, Eoghan <[EMAIL PROTECTED]> wrote:
> >
> >
> >
> > Folks,
> >
> > After tearing my hair out for the last hour as to why some
> > <jaxws:client> config seemed no longer to be working as before, it
> > looks like the abstract="true" attribute on this element
> needs to be
> > replaced by createdFromAPI="true".
> >
> > What does createdFromAPI mean in this context? That the proxy is
> > created via Service.getPort(), or?
> >
> > Also is this the only change required to restore the
> previous semantics?
> >
> > Whoever made the change, probably a good idea to also update any
> > system tests and/or demos that use this config, prior to
> the release.
> > A quick grep suggests this applies to the coloc demo and
> system tests
> > at least, maybe others too.
> >
> > Cheers,
> > Eoghan
> >
> >
>
>
> --
> Dan Diephouse
> Envoi Solutions
> http://envoisolutions.com | http://netzooid.com/blog
>
