Re: Unused parameter in CXFBusImpl.shutdown(boolean wait)

[Polar Humenn]

Seumas,

The "shudown(boolean wait)" operation is part of the org.apache.cxf.Bus 
interface, which the CXFBusImpl implements. You can't take the "wait" 
parameter out of it.

Cheers,
-Polar

Soltysik, Seumas wrote:
Hi Willem,
Potentially this is a valid parameter, but since it is not used, it should not 
be a parameter. I am surprised there is not a checkstyle rule to check for 
un-used parameters.
Regards,
Seumas

-----Original Message-----
From: Willem Jiang [mailto:[EMAIL PROTECTED]
Sent: Thursday, June 21, 2007 5:15 AM
To: cxf-dev@incubator.apache.org
Subject: Re: Unused parameter in CXFBusImpl.shutdown(boolean wait)


Hi Seumas,

I just has a use case for want to call Bus.shutdown(true)  when the 
WorkQueue still has jobs to do.

Any thoughts?

Willem.

Soltysik, Seumas wrote:
  
Currently CXFBusImpl.shutdown(boolean wait) takes an unused wait parameter. Is 
there any intent to make use of this parameter? If not, it should be removed.
Regards,
Seumas

    public void shutdown(boolean wait) {
        lifeCycleManager = this.getExtension(BusLifeCycleManager.class);
        if (null != lifeCycleManager) {
            lifeCycleManager.preShutdown();
        }
        synchronized (this) {
            state = BusState.SHUTDOWN;
            notifyAll();
        }
        if (null != lifeCycleManager) {
            lifeCycleManager.postShutdown();
        }
        if (BusFactory.getDefaultBus(false) == this) { 
            BusFactory.setDefaultBus(null);
        }
    }