Dan, That all sounds fine. If you tell me where you want it in your tree, I can set up a pom, fix up all the checkstyle issues, etc.
I intentionally didn't put the Apache headers in place until I get the CLA submitted, I don't want anyone to yell at me for pretending to make a contribution without the legal backup. I should warn you that we haven't tested it on anything like a comprehensive supply of WSDL files. An entirely selfish reason to contribute it is to see if anyone else will pitch in. Also, if we make it possible to pull the resulting js out of a URL, we should probably include the supporting javascript (which I didn't bother to attach to the initial review version). --benson > -----Original Message----- > From: Dan Diephouse [mailto:[EMAIL PROTECTED] > Sent: Thursday, July 19, 2007 3:58 PM > To: [email protected] > Subject: Re: Contribution of wsdl2js tool > > Hi Benson, > > Thanks for taking the initial steps with this contribution (and for your > other unit test contributions so far). > > I've taken an initial look through the code and wanted to relay some > thoughts. First, I like the way you've done this. Its simple - I was > trying > to do something way more complicated back in the day and I think this way > is > probably much better :-). I have yet to try it out on any actual services > though ;-) > > My next thought is that if we're going to accept this contribution, we > would > need to get it inside our build. We can help give you guidance on this. > Basically we just need to get it Mavenized, in the standard directory > layout, set up with the appropriate Apache license headers, conforming to > our Checkstyle/PMD rules, etc. > > Lastly, I think it'd be really cool if we hooked this into CXF such that > someone could call http://localhost/fooService?js and get out a javascript > client. CXF has a QueryHandler interface which we can implement to do this. > That is how ?wsdl is supported as well. > > Cheers, > - Dan > > On 7/19/07, Benson Margulies <[EMAIL PROTECTED]> wrote: > > > > OK, time to join the dev list. Will do. > > > > > -----Original Message----- > > > From: Dan Diephouse [mailto:[EMAIL PROTECTED] > > > Sent: Thursday, July 19, 2007 11:29 AM > > > To: [EMAIL PROTECTED] > > > Subject: Re: Contribution of wsdl2js tool > > > > > > Hi Benson, > > > > > > Such contributions are definitely welcome! > > > > > > I believe there are a few major things that need to happen. You would > > need > > > to package the code under an ASL license and send along Corporate CLA > > [1]. > > > The CXF community would also need to vote on the contribution and > > possible > > > committers. There may also be some incubator related things we need to > > do. > > > I'll do some digging and will report back with more info. > > > > > > Also, it might be good to redirect this discussion to the dev list. > > > > > > Cheers, > > > - Dan > > > > > > 1. http://www.apache.org/licenses/#clas > > > > > > On 7/19/07, Benson Margulies <[EMAIL PROTECTED]> wrote: > > > > > > > > Dear CXF team, > > > > > > > > > > > > > > > > Basis Technology would like to contribute our wsdl2js tool to CXF > > under > > > > the usual ASF license. > > > > > > > > > > > > > > > > The tool consists of Java source code that uses the same WSDL > > library > > > > that CXF already uses and generates Javascript code that targets > > some > > > > JavaScript utility functions that work in Firefox and IE (and > > probably > > > > others). > > > > > > > > > > > > > > > > What is the mechanics of this process? I could tar up the whole > > business > > > > and append it to a JIRA. You could consider accepting me as a > > committer. > > > > You could ask me to post it for review some other way. > > > > > > > > > > > > > > > > --benson > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Dan Diephouse > > > Envoi Solutions > > > http://envoisolutions.com | http://netzooid.com/blog > > > > > > -- > Dan Diephouse > Envoi Solutions > http://envoisolutions.com | http://netzooid.com/blog
