Thanks for your comment, it is really a big mistake that I made. I will
update it very soon.
Thanks
Jeff
Glen Mazza wrote:
Comments below:
+ setAttachementOutputStreamProperties(bos);
+ private void
setAttachementOutputStreamProperties(CachedOutputStream bos) throws
IOException {
Attachment is misspelled above in the two places.
-------------------------------------------------------------------
+ public static final int THRESHOLD = 1024 * 100; // ???
If you could add a single line comment giving the units the measure here
(replace my ??? above with "seconds", "bytes", whatever it is)
-------------------------------------------------------------------
private void setAttachementOutputStreamProperties(CachedOutputStream
bos) throws IOException {
+ Object directory =
message.getContextualProperty(ATTACHMENT_DIRECTORY);
+ if (directory != null) {
+ if (directory instanceof File) {
A bos.setOutputDir((File)directory);
+ }
B bos.setOutputDir(new File((String)directory));
+ }
OK, last time I did this with Dan K I turned out to be embarrassingly
wrong. But I will try again:
If directory is an instanceof File, not only line A but also line B will
be run. I don't think that's what you want.
----------------------------------------------------------------------
+
+ Object threshold =
message.getContextualProperty(ATTACHMENT_MEMORY_THRESHOLD);
+ if (threshold != null) {
+ if (threshold instanceof Long) {
+A bos.setThreshold((Long)threshold);
+ }
+B bos.setThreshold(Long.valueOf((String)threshold).longValue());
Same story here I think.
Regards,
Glen
Am Donnerstag, den 09.08.2007, 11:56 +0800 schrieb Jeff.Yu:
Hi,
I've provided a patch, with a very little change. Can someone please
help me review and apply it if it is okay.
Thanks
Jeff
Daniel Kulp wrote:
On Monday 06 August 2007 01:12, petrica wrote:
Hi all,
Is there in CXF on the client side something like in XFire for MOTM
attachments ( see below ) ?
service.setProperty(StreamedAttachments.ATTACHMENT_DIRECTORY, new
File( "c:\\temp\\" ));
I just checked the code and I don't see anything right now. I've logged
a Jira to track it as it's a very good idea:
https://issues.apache.org/jira/browse/CXF-888