Jim, If you don't get around to committing the new content before you stop work for this evening (you're in China, right), I'll post a replaced version with Glen's requested comments before your tomorrow AM.
--benson > -----Original Message----- > From: Jim Ma [mailto:[EMAIL PROTECTED] > Sent: Monday, September 17, 2007 7:38 AM > To: [email protected] > Subject: Re: svn commit: r575222 - in > /incubator/cxf/trunk:api/src/main/java/org/apache/cxf/tools/common/ > tools/common/tools/common/src/main/java/org/apache/cxf/tools/common/ > tools/javato/tools/javato/ws/ > tools/javato/ws/src/main/java/org/apache/cxf/tools/java2 > > Hi Benson , > > I have committed the patch in file java2wsdiff.txt . > <https://issues.apache.org/jira/secure/attachment/12365504/java2wsdiff.t xt > > > The another file is not committed . > > Regards > > Jim > > > Benson Margulies wrote: > > Easily done. Jim, have you committed 807 yet? If not, I'll supply a > > separate patch for the comments. > > > > Glen, I hope that you've noticed my tendency to fix spelling errors > > whenever I see them as a counterbalance to occasionally murky items. > > > > > >> -----Original Message----- > >> From: Glen Mazza [mailto:[EMAIL PROTECTED] > >> Sent: Monday, September 17, 2007 12:16 AM > >> To: [email protected] > >> Subject: RE: svn commit: r575222 - in > >> /incubator/cxf/trunk:api/src/main/java/org/apache/cxf/tools/common/ > >> tools/common/tools/common/src/main/java/org/apache/cxf/tools/common/ > >> tools/javato/tools/javato/ws/ > >> tools/javato/ws/src/main/java/org/apache/cxf/tools/java2 > >> > >> OK, then for your next patch, if you add a quick comment to that > >> > > source > > > >> file indicating what "singular" and "multiple" mean--the reader would > >> not necessarily know they need to check an .xml file for the > >> definitions. > >> > >> Thanks, > >> Glen > >> > >> Am Sonntag, den 16.09.2007, 22:56 -0400 schrieb Benson Margulies: > >> > >>> Multiple and singular are meaningful. See the .aegis.xml file that > >>> > > sets > > > >>> maxOccurs for them: singular has maxOccurs=1, multiple is unbounded. > >>> > > So > > > >>> I think these names make the test case that uses them more readable. > >>> > >>> > >>>> -----Original Message----- > >>>> From: Jim Ma [mailto:[EMAIL PROTECTED] > >>>> Sent: Sunday, September 16, 2007 10:25 PM > >>>> To: [email protected] > >>>> Subject: Re: svn commit: r575222 - in /incubator/cxf/trunk: > >>>> api/src/main/java/org/apache/cxf/tools/common/ tools/common/ > >>>> tools/common/src/main/java/org/apache/cxf/tools/common/ > >>>> > > tools/javato/ > > > >>>> tools/javato/ws/ > >>>> > >>> tools/javato/ws/src/main/java/org/apache/cxf/tools/java2 > >>> > > > >
