---------- Forwarded message ---------- From: Guillaume Nodet <[EMAIL PROTECTED]> Date: Sep 18, 2007 9:14 AM Subject: Re: Logging framework To: Daniel Kulp <[EMAIL PROTECTED]>
I thought about that. The only problem is that Logger is a class and its own factory (thanks for extensibility design). It also mixes concern like logging and configuration. Keeping the Logger class does not ensure which methods are used in the CXF code base. We can implement our own LogManager to create our derived Logger, but this is a system global variable to configure, which means it has side effect on all the VM :-( Also, it does not work because the LogManager is initialized only once when the logging system is initialized, which means that when CXF is loaded, it may already be too late to set our own LogManager. I wish your idea could work, that would be much easier... On 9/18/07, Daniel Kulp <[EMAIL PROTECTED]> wrote: > > > Guillaume, > > All creation of Logger objects now go through the > LogUtils.createL7nLogger(...) calls. Thus, IMO, you should just update > those two methods to wrapper things like Log4j with something that > implements the Logger interface and return that. That would be the > lowest impact on existing code, we could all still use the j.u.l API's, > etc... (except we need to make sure to create the loggers through > LogUtils, which we should anyway for i18n reasons.) > > > > Dan > > > > On Monday 17 September 2007, Guillaume Nodet wrote: > > It seems CXF logging uses java.util.logging, which is fine > > for a standalone product, but not so fine when integrating CXF > > inside another product (thinking about geronimo, servicemix, etc...). > > The main problem is that lots of products uses log4j or another > > logging mechanism, and not being able to integrate and use the > > same logging mechanism is imho a real pain for users who want to > > debug and see what happens. > > > > I'm thinking about creating a interface > > org.apache.cxf.common.logging.Logger that would be used instead of the > > java.util.logging.Logger class. The LogUtils > > helper class would reuse a default implementation using > > java.util.logging, while other products could implement their own > > version to wrap their preferred logging api. > > > > Thoughts ? > > > > -- > J. Daniel Kulp > Principal Engineer > IONA > P: 781-902-8727 C: 508-380-7194 > [EMAIL PROTECTED] > http://www.dankulp.com/blog > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/
