Re: svn commit: r599337 - in /incubator/cxf/trunk: rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ systests/src/test/java/org/apache/cxf/systest/interceptor/

[James Mao]

I'm trying to match the wsdl:fault name in the wsdl from the @WebFault 
annotation from the exception class,

The name in the @WebFault is StringUtils.capitalized when generating the 
exception class during the wsdl2java.

So, I think it's OK

Regards,
James

Am Donnerstag, den 29.11.2007, 08:42 +0000 schrieb [EMAIL PROTECTED]:
  
Author: mmao
Date: Thu Nov 29 00:42:32 2007
New Revision: 599337

URL: http://svn.apache.org/viewvc?rev=599337&view=rev
Log:
CXF-1191
 * Fix the NEP, enable the tests disabled in the last commit

Modified:
incubator/cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java
URL: 
http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java?rev=599337&r1=599336&r2=599337&view=diff
==============================================================================
--- 
incubator/cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java
 (original)
+++ 
incubator/cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java
 Thu Nov 29 00:42:32 2007
@@ -420,6 +420,9 @@
     }
 
     private boolean isSameFault(final FaultInfo faultInfo, String faultName) {
+        if (faultInfo.getName() == null || faultName == null) {
+            return false;
+        }
         String faultInfoName = faultInfo.getName().getLocalPart();
         return faultInfoName.equals(faultName) 
             || faultInfoName.equals(StringUtils.uncapitalize(faultName));

    

Are you sure case insensitivity should be allowed here?  That doesn't
seem rigorous, but I'm not sure of the purpose of this code.

Glen