Re: svn commit: r606834 - /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java

[James Mao]

Glen,

It's defined in the JAXWS spec, in section 11.1.1.1
> Conformance (Incompatible handlers): Implementations MUST throw a 
WebServiceException when
>            attempting to configure an incompatible handler using 
Binding.setHandlerChain

That said, in case of HttpBinding, if you add SoapHandler or other 
protocol handlers, it must throw the WebServiceException

James


James, pardon me but I don't understand the code here very well.

Your latest patches are limiting JAX-WS handlers to be just
LogicalHandlers (and not SOAPHandlers).  Question:  where are you doing
this limitation and under what circumstances is this limitation in
place--for clients? for web service implementations?  Just for
programmatic configuration?

Thanks,
Glen

Am Mittwoch, den 26.12.2007, 03:05 +0000 schrieb [EMAIL PROTECTED]:
  
Author: mmao
Date: Tue Dec 25 19:05:53 2007
New Revision: 606834

URL: http://svn.apache.org/viewvc?rev=606834&view=rev
Log:
* Fix the checks 


Modified:
    
incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java

Modified: 
incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
URL: 
http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java?rev=606834&r1=606833&r2=606834&view=diff
==============================================================================
--- 
incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
 (original)
+++ 
incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
 Tue Dec 25 19:05:53 2007
@@ -48,8 +48,8 @@
     private void validate() {
         for (Handler handler : this.getHandlerChain()) {
             if (!(handler instanceof LogicalHandler)) {
-                throw new WebServiceException("Adding an incompatible handler in javax.xml.ws.http.HTTPBinding: " 
-                        + handler.getClass());
+                throw new WebServiceException("Adding an incompatible handler in 
HTTPBinding: "
+                                              + handler.getClass());
             }
         }        
     }