Late test for null object reference - check intent
--------------------------------------------------
Key: CXF-177
URL: http://issues.apache.org/jira/browse/CXF-177
Project: CXF
Issue Type: Bug
Components: WS-* Components
Affects Versions: 2.0-M1
Reporter: Michael Bricout
Priority: Minor
I stumbled accross this while browsing through the code. It may be of no
consequence, however it might be worth double checking the intent:
In org.apache.cxf.ws.addressing.ContextUtils.isOutbound(Message message): we
call message.getExchange(), then only after that we check for a null message.
public static boolean isOutbound(Message message) {
Exchange exchange = message.getExchange();
return message != null
&& exchange != null
&& message == exchange.getOutMessage();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
