[
https://issues.apache.org/jira/browse/CXF-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529428
]
maomaode commented on CXF-1000:
-------------------------------
Dan,
The ordering will not fail the tests, the assertWsdlEquals already take that
into account, the only thing will fail the tests is the anonymous types v.s non
anonymous types.
I agree with you though, we should use the xpath for the latter tests.
The reason I replace assertWsdlEquals with assertFileEquals is that i don't
know how many xpath i'll need to write for the existing tests, as you saw, i
didn't change any testing resources.
> Remove string compares of XML from unit tests
> ---------------------------------------------
>
> Key: CXF-1000
> URL: https://issues.apache.org/jira/browse/CXF-1000
> Project: CXF
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Daniel Kulp
>
> There are a lot of tests that are doing striaght string compares of XML
> results with files on the disk. This makes it harder than necessary to
> update things when behavior changes. (like different XML serialization
> routine used).
> The tests should either normalize the XML and use a normalization compare
> routine, or preferably, use XPATHS to test specifically if the interested
> nodes and information that the test is actually testing is in the XML so the
> format of the XML is irrelevant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
