=== ----- Original Message ----- From: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, January 24, 2002 9:52 AM Subject: Re: setup.exe command line options
> ----- Original Message ----- > From: "Christopher Faylor" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Wednesday, January 23, 2002 10:39 PM > Subject: Re: setup.exe command line options > > > > >I'm wondering if I could submit what I have so far, and either leave some > > >bits #ifdef'd out (how does the undefined macro > > >COMMAND_LINE_OPTIONS_FULLY_IMPLEMENTED sound!?) or just miss those bits > out > > >completely from my diff. > > > Does it even need to be commented out? It seems like, if it works > partially, > > we just have a partial implementation. No need to suffer the bit rot > assocated > > with ifdefs. > > For the options that don't work, should I leave in the working getopt code > and take out the broken implementation? > > Also, incorrect usage, or --help pops up a window. Should I take that out > completely, ammend it to only include working options, or show all the > options that I wanted to work? At this point, if it builds and runs, send it in. Few patches that change architecture (as this does) get in on the first submission, so minimise your effort. Rob
