Hello Robert, Friday, March 29, 2002, 10:25:08 AM, you wrote:
>> > Found the problem causing the segment violation and probably >> > causing Jonas Eriksson's problem. It is a typical case of >> > 'off by 1'. In PickView::set_headers the loop filling the >> > window header does one iteration too much, resulting in a >> > call to DoInsertItem with a NULL string pointer and hence a >> > crash following. While debugging this I could not compile the >> > new mklink2.cc ( the >> > c++ version of the original mklink2.c). It seems three & (address of >> > c++ operator) >> > have disappeared in the transition. Putting them back made >> > the compiler happy. Is this OK Robert ? >> >> I'll check the off-by-one fix in tomorrow, as I'm off to bed now. RC> Actually, this is not an off-by-one error. It's an invalid data error - RC> the loop is meant to go from 0 to == last_col, where last col is meant RC> to be equal to the greatest column number. The first set of column RC> details had last_col set incorrectly. Btw I don't think my question is related to this is issue but still... I notice there is a dummy column in the list view after the "Package" column - is this a feature ? If so what is its purpose ?
