Re: rebase / STL set patch

[Jason Tishler]

Rob,

On Thu, Aug 29, 2002 at 01:51:55AM +1000, Robert Collins wrote:
> On Thu, 2002-08-29 at 01:44, Jason Tishler wrote:
> > Huh?  Do you mean the RebaseConfigParser::parseFoo diffs?
> 
> The missing return true from the parser submethods. status=foo(), and
> foo() didn't return a value.

Oops on my part -- I'm actually surprised that the compiler didn't catch
these...

> * follow the GNU guidelines where they don't contradict what I've just
> said.

What about the following C++-ish stuff not (really) covered by the GNU
coding conventions?

    o constructor initialization formating:

      RebaseConfigBuilder::RebaseConfigBuilder (const string &aFileName) :
        theStream (aFileName.c_str (), ios::binary)

      or

      RebaseConfigBuilder::RebaseConfigBuilder (const string &aFileName)
        : theStream (aFileName.c_str (), ios::binary)

      or

      RebaseConfigBuilder::RebaseConfigBuilder (const string &aFileName) : theStream 
(aFileName.c_str (), ios::binary)

      or

      ?

    o whitespace formatting:

      const string &aFileName;
                  ^
      
      or

      const string& aFileName;
                   ^
    o method formatting (i.e., capitalization):

      bool parseFreeList (...);
           ^
      or

      bool ParseFreeList (...);
           ^

    o data member formatting:

      RebaseFreeList theFreeList;

      or

      RebaseFreeList freeList;

      or

      RebaseFreeList freeList_;

      or

      ?

    o etc?

Thanks,
Jason