On Tue, 8 Oct 2002, Ryunosuke Satoh wrote:

> Updated.
> 
>http://www.geocities.co.jp/SiliconValley-SanJose/5153/cygwin-package/doxygen-1.2.18-1-package.tgz
> CHANGES:
>        compiled with -fno-exceptions and -fno-rtti.
>
> > doxygen compiled with -fno-exceptions and -fno-rtti
> > So I think adding these two options to the list of flags passed to g++
> > would be useful.
>

Just reviewed it:

1) The hunk starting at line 10474 of the patch is unnecessary

2) The hunk starting at line 10479 seems unnecessary too - you don't
link against the included libpng.

3) I'm not quite sure but it seems like you made the patch against some
already patched version of doxygen-1.2.18 and not the original one.

4) You used the '-fno-exceptions -fno-rtti' flags only in the Makefile
responsible for building libdoxygen.a, while it can be used also in
libdoxycfg.pro.in, doxygen.pro.in, doxygen.pro.in, doxysearch.pro.in,
doxytag.pro.in and qtools.pro.in.A


Reply via email to