On 25 Mar 2003, Robert Collins wrote:
> + for (i = packages.begin (); i != packages.end (); ++i)
> + {
> + packagemeta & pkg = **i;
> + for_each (pkg.installed.scripts().begin(), pkg.installed.scripts().end(),
> + RunScript(pkg.name, pkg.installed.scripts().size()));
> + ++k;
> + Progress.SetBar2 (k, numpkg);
> + }
>
> I was thinking that this would be part of RunScript - you've taken the
> innermost aspect of it's operation.. I was thinking it would be a little
> bit more encompassing - thus the run method.
>
> Hmm, I'm not sure that this can be done cleanly just now though, so...
Yes, doing so would have required tacking on a dummy packagemeta onto the
end of the list. Then RunScript would have traversed the list of
packagemeta pointers... Either that, or yet another helper class that
would store a package name and a pointer to a vector of Scripts...
Either way, I didn't think it was worth the trouble.
> Max, can you please check this in?
> Cheers,
> Rob
Thanks,
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ [EMAIL PROTECTED]
ZZZzz /,`.-'`' -. ;-;;,_ [EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
-- /usr/games/fortune
