> On Fri, 2003-03-28 at 17:44, Gary R. Van Sickle wrote: > > Bigger and better than ever baby YEAH! > > > > Changes from the last patch: > > - Finish problem fixed. > > - "Back" button on splash page disabled again. > > - Bonus: two new icon resolutions! > > > > Only known problem is the bottom separator line still goes all the > way to the > > edge of the dialog (i.e. there's no margin) on the regular-sized > pages. Not a > > huge visual problem. > > This is cool. I hope to get a chance to review it soon.... > but: > > it's too big for a single commit. I'd like you to start sending in the > bits that you can, in a > single-patch-does-a-single-conceptual-change style. > > Those I can review and approve for Max or I to checkin. >
Are you saying you won't review and approve this patch as-is? > As an example: The signature change for OnActivate from void to long is > a single change - you could do a patch just for that, returning 0 from > everything and ignoring the result. > > Bad example probably, but it should give you the idea. > > Cheers, > Rob > -- > GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>. > -- Gary R. Van Sickle Brewer. Patriot.
