Robert Collins wrote: > On Mon, 2003-07-28 at 19:46, Max Bowsher wrote: >> Another cleanup patch. The remaining user of next_dialog, do_fromcwd, >> requires slightly more invasive refactoring, hence is not included with >> these changes. > > I think this is the wrong way to solve both these issues. > > I'd prefer we setup a class for each of ini processing and downloading, > which can be queried for status. Then the calling function decides on > next_dialog based on interrogation, rather than the callees deciding.
I agree, but feel that this is an incremental step towards the goal of cleaner code design. At the moment, next_dialog is a global variable which no longer possesses global significance, serving only to make the code harder to understand. I don't think that the fact that a big cleanup is possible should prevent a small cleanup from being done. Max.
