Rafael, Thanks very much for the review. I've got a lot going on right now, but I'll do my best to clean things up and post a new package soon.
-Samrobb > -----Original Message----- > From: Rafael Kitover [mailto:[EMAIL PROTECTED] > Sent: Thursday, February 05, 2004 8:29 AM > To: [EMAIL PROTECTED] > Subject: [Review - Not Good To Go] dhcp 3.0.1rc11-1: ISC DHCP > reference > implementation > > > Can't do an in-depth review, but some major problems I > noticed at a quick > glance: > > * man pages are installed incorrectly as formatted output > instead of troff > source, eg. "man dhcpd.conf" prints a stream of garbage > > * there are no default config files and no example config > files (look at some > of the Debian dhcp packages for ideas) > > * dhclient doesn't seem to work, unless I'm missing something: > > ipconfig /all > ... > Dhcp Enabled. . . . . . . . . . . : No > ... > > dhclient > Internet Software Consortium DHCP Client V3.0.1rc12-cygwin-pxe1 > Copyright 1995-2002 Internet Software Consortium. > All rights reserved. > For info, please visit http://www.isc.org/products/DHCP > > execve (/sbin/dhclient-script, ...): No such file or directory > Listening on Socket/eth0 > Sending on Socket/eth0 > DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 3 > DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 8 > DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 7 > DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 14 > DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 21 > ... > > and so on > > Then again, I don't know anything about what corresponds to "eth0" in > dhcp/Cygwin. > > If you just want to make a dhcp server package (dhcpd I did > not have time to > test) and the client is broken, then it shouldn't be in the package. > > * there is no package script > > * some suspicious warnings like: > > dispatch.c: In function `omapi_one_dispatch': > dispatch.c:303: warning: passing arg 2 of `select' from > incompatible pointer > type > > and other less suspicious ones > > * I'm getting a core dump in the build: > > gcc -g -Wl,-s -o svtest. test.o ../minires/libres.a \ > libomapi.a ../dst/libdst.a > collect2: ld terminated with signal 11 [Segmentation fault], > core dumped > > This of course may not have anything to do with the package... > > -- > Rafael > > >
