On Tue, 20 Sep 2005, Eric Blake wrote:
> Dependency calculation should not do transitive closure, but should only
> list direct library dependencies. For example, something that depends on
> only libxml2 should not also depend on libiconv2. Otherwise, if libxml2
> is recompiled to depend on a (theoretical) new libiconv3, the package that
> depended on libxml2 pulls in the now unneeded libiconv2 in addition to
> setup.exe correctly recognizing that libiconv3 is needed.
>
> http://cygwin.com/setup.html agrees with this, stating "Conversely, do not
> include package dependencies of dependent packages in your dependency
> list." So, this patch fixes g-b-s to only grab direct dependencies,
> rather than everything:
>
> 2005-09-20 Eric Blake <[EMAIL PROTECTED]>
>
> * templates/generic-build-script (depend): Don't do transitive
> closure, only direct dependencies.
Eric,
You also included a few whitespace changes in your patch -- while I don't
mind cleanups, it would've been nice to explicitly mention them. Also,
your RE to detect dependencies ('/^ [[:alpha:]]/') seems wrong -- IMO,
it'll miss DLLs that start with digits or underscores. I've changed it
accordingly (to '/^ [A-Za-z0-9_]/') and checked in the patch with that
change.
Thanks for the patch.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ [EMAIL PROTECTED]
ZZZzz /,`.-'`' -. ;-;;,_ [EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA
