On Mon, 10 Oct 2005, Dr. Volker Zell wrote:

> @@ -340,6 +349,7 @@
>      cp $0.sig ${srcinstdir}/ ; \
>    fi && \
>    cd ${srcinstdir} && \
> +  tar cvjf ${log_pkg_name} *.LOG && rm *.LOG && \
>    tar cvjf ${src_pkg} * )
>  }
>  finish() {

One small issue here: would it make sense to list the files explicitly for
both "tar" and "rm", instead of just using *.LOG?  Suppose the variable
values get changed?

This would, of course, require some rethinking of the variable values
(i.e., the explicit path), or we could just change it to

+  tar cvjf ${log_pkg_name} ${configurelogfile%%${srcinstdir}/} \
+       ${makelogfile%%${srcinstdir}/} ${checklogfile%%${srcinstdir}/} \
+       ${installlogfile%%${srcinstdir}/} && \
+    rm *.LOG ${configurelogfile%%${srcinstdir}/} \
+         ${makelogfile%%${srcinstdir}/} ${checklogfile%%${srcinstdir}/} \
+         ${installlogfile%%${srcinstdir}/} && \

(using bash-isms).

Comments?
        Igor
-- 
                                http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_                [EMAIL PROTECTED]
ZZZzz /,`.-'`'    -.  ;-;;,_            [EMAIL PROTECTED]
     |,4-  ) )-,_. ,\ (  `'-'           Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL     a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA

Reply via email to