On Fri, Apr 24, 2009 at 08:30:36PM +0100, Dave Korn wrote: > > Prompted by Marcio (thanks!), I went back to the setup.exe filter search > patch. > > The one outstanding issue, you may remember, was the need to set a minimum >size for the setup dialog, to prevent horrible ugliness when the controls >overdrew each other or went outside the client area. > >On investigation, it turns out that we already had a serviceable >minimum-size mechanism, which was disabled in r2.10 of propsheet.cc >when cgf was adding the auto-maximization of the chooser page. The >ChangeLog comment doesn't refer to this, so PING cgf: was this an >inadvertent change? I tried reverting it and it doesn't appear to be >necessary for the auto-maximization to function correctly, nor could I >see anything wrong with using the initial layout size as a minimum.
If you are talking about the commenting out of psd.hasMinRect = true; then it looks like that was unintentional. > So here's an updated and retested version of the patch done under the >assumption that reverting that change will be acceptable; if not, I can find a >different way of doing it. Ok for head? > > >2009-03-27 Andrew Punch <[email protected]> > > * PickView.h: Add #include <string>. > (PickView::SetPackageFilter): Add new function. > (PickView::packageFilterString): Add new string data member. > * PickView.cc (PickView::setViewMode): Use it to filter names. > (PickView::insert_category): Likewise. > (PickView::PickView): Initialise packageFilterString to blank. > * res.rc (IDD_CHOOSE): Add IDC_CHOOSE_SEARCH_EDIT and > IDC_CHOOSE_SEARCH_LABEL controls. > (IDS_SEARCH_TOOLTIP): Add new string resource. > * resource.h (IDS_SEARCH_TOOLTIP): New string resource ID. > (IDC_CHOOSE_SEARCH_EDIT): New edit control ID. > (IDC_CHOOSE_SEARCH_LABEL): Mew static text control ID. > * choose.cc (ChooserControlsInfo[]): Add IDC_CHOOSE_SEARCH_LABEL > and IDC_CHOOSE_SEARCH_EDIT controls to auto-resize list. > (ChooserPage::OnInit): Add tooltip to search edit box. > (ChooserPage::OnMessageCmd): Handle EN_CHANGE event from > IDC_CHOOSE_SEARCH_EDIT. Looks good. Thanks. cgf
