On Sat, May 22, 2010 at 12:57:25PM -0400, Christopher Faylor wrote: >On Sat, May 22, 2010 at 08:52:29AM -0700, Brendan Conoboy wrote: >>On 05/21/2010 11:18 PM, Christopher Faylor wrote: >>> This comment in RootPage::OnNext would suggest that this was already >>> supposed to have been handled. >>> >>> /* Deferred initialization of packagedb *after* the root dir has been >>> chosen. */ >> >>It appears you're looking at rev 2.25 of root.cc, while I'm looking at >>the latest, 2.26 which doesn't have that. Dave Korn's changelog entry: >> >>2010-04-17 Dave Korn <[email protected]> >> >> * root.cc (RootPage::OnNext): Don't construct a packagedb here nor >> do deferred initialisation of static packagedb::task. >> * source.cc (save_dialog): Don't construct a packagedb here, and >> set static packagedb::task directly instead of chosen_db_task. >> * package_meta.cc (packagemeta::action_caption): Don't bother to >> construct a packagedb here, just access packagedb::task directly. >> * package_db.cc: Move 'static members' comment near static members. >> (chosen_db_task): Delete. >> * package_db.h (chosen_db_task): Don't declare extern. >> (packagedb): Extend comments on class. >> >>Presumably this has caused the problem. Dave, what was the goal of this >>patch? > >The archives are your friend. > >http://cygwin.com/ml/cygwin-apps/2010-04/threads.html#00037
Dave, it looks like your recent change broke this. Do you have any suggestions for fixing it? cgf
