On Fri, Jul 30, 2010 at 04:44:24PM -0400, Christopher Faylor wrote: >On Fri, Jul 30, 2010 at 08:19:20PM +0100, Dave Korn wrote: >>On 30/07/2010 15:37, Christopher Faylor wrote: >> >>> errors" page. The only two packages that should have been installed >>> were >>> >>> gcc: C compiler upgrade helper >>> glib: Gnome C function library (1.2 sources) >>> >>> (both of which are selected due to a setup.exe bug) >> >> I finally got bored of this one. Turned out to be trivially easy to fix >>once I looked at it, it's simply an early exit from the install routine when >>there's nothing to do for a dummy tarball (zero or 46-byte size) that misses >>out on marking the package as installed. >> >>setup/ChangeLog: >> >> * install.cc (Installer::installOne): Also record zero-sized >> tarballs as successfully installed. >> >> OK? > >Yes! This is great. Thank you for fixing this.
Actually, I barely care but would it be better to just use a goto the if statement at the end of that function and exit from the bottom? If you don't think it's a good idea then nevermind. Whatever it takes to finally fix this is fine with me. cgf
