On 6 August 2010 21:36, Christopher Faylor wrote: > On Fri, Aug 06, 2010 at 10:26:02PM +0200, Corinna Vinschen wrote: >>Here's another test with only selecting the vorbis-tools package. >>With the current setup from CVS: >> >> Package: libao4 >> Required by: vorbis-tools >> >> Package: libFLAC8 >> Required by: vorbis-tools >> >> Package: libkate1 >> Required by: vorbis-tools >> >> Package: libogg0 >> Required by: vorbis-tools >> >> Package: libspeex1 >> Required by: vorbis-tools >> >> Package: libvorbis0 >> Required by: vorbis-tools >> >> Package: libvorbisenc2 >> Required by: vorbis-tools >> >> Package: libvorbisfile3 >> Required by: vorbis-tools >> >>With my patch: >> >> Package: libao >> Required by: libao4 >> >> Package: libao-devel >> Required by: libao >> >> Package: libao4 >> Required by: vorbis-tools >> >> Package: libaudio2 >> Required by: libao4 >> >> Package: libaudiofile0 >> Required by: libesd0 >> >> Package: libesd0 >> Required by: libao4 >> >> Package: libFLAC8 >> Required by: vorbis-tools >> >> Package: libkate >> Required by: libkate1 >> >> Package: libkate1 >> Required by: vorbis-tools >> >> Package: libogg0 >> Required by: vorbis-tools >> >> Package: libspeex1 >> Required by: vorbis-tools >> >> Package: libvorbis >> Required by: libvorbis0 >> >> Package: libvorbis0 >> Required by: vorbis-tools >> >> Package: libvorbisenc2 >> Required by: vorbis-tools >> >> Package: libvorbisfile3 >> Required by: vorbis-tools >> >> >>Looks still good, doesn't it? > > Yep. Andy do you agree?
I'm still working on a patch that tries to address this without a second dependency checking loop, by putting all desired packages into a todo list at the start, and then adding to it as we go through it and find missing dependencies. But since Corinna got there first ... . Doesn't the first loop need a (*n).first->prereq_checked (true) as well though? Andy
