On Nov 19 11:07, Christopher Faylor wrote: > On Sat, Nov 06, 2010 at 05:05:15PM +0000, Jon TURNEY wrote: > >Currently, if, for example, I manually add the site > >http://mirrors.kernel.org/sources.redhat.com/cygwinports/ > >to setup's mirror list, I get two indistinguishable entries named > >http://mirrors.kernel.org. > > > >Furthermore, because the code to ensure the site just added is selected uses > >the string inside the list control > >to locate elements, we end up with a random one of those two > >indistinguishable entries selected (usually the > >previously existing one). This problem also prevents the selected sites > >being correctly saved and restored > >for the next setup run. > > > >So, to make the site chooser list entries unique and distinguishable, add > >the last element of the URL path to > >the site chooser, if it exists and isn't 'cygwin' (or some other > >alternatives used by current mirrors) > > > >(Also fix the logic for identifying protocol and site name part of the URL > >to find the first '/' after a '//', > >rather than the first '/' after a '.', to handle sitenames which aren't > >FQDNs correctly) > > > >2010-11-06 Jon TURNEY <[email protected]> > > > > * site.cc (init): If interesting, Show the last element of URL, as well > > as the protocol and sitename in the site chooser > > I like this better than my idea of showing the full URL. Unless there > are objections (Corinna?) please check in.
No objections. Just go ahead. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
