On Jun 21 09:50, Charles Wilson wrote: > On 6/21/2011 9:30 AM, Corinna Vinschen wrote: > > On Jun 21 09:07, Charles Wilson wrote: > >> On 6/21/2011 8:39 AM, Jason Tishler wrote: > >>> OK to apply? > >> > >> Tab/space issues these lines (twice): > >> + verbose ? old_coff_characteristics : 0, > > > > What's the issue? To use tabs is an issue? Usually only using spaces > > is the issue... > > I just noticed that in the diff, it looked this way: > > - pe_characteristics_show, > + pe_characteristics_show ?: > + verbose ? old_pe_characteristics : 0, > > This is usually an indication that, e.g. all-spaces were used in the > "more indented" line, but that a tab or two was used in the other one. > Consistency is good. :-) > > However, as you've already checked it in, no worries.
The checked-in patch uses all-spaces like the surrounding lines. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
