On 8/3/2011 10:43 AM, Corinna Vinschen wrote: > Ok, here's my final(?) patch to make setup install mintty as "Cygwin > Terminal" desktop and start menu entries. Apart from the cygwin.ico > file, there's now also a cygwin-terminal.ico file and a cygwin-setup.ico > file. The latter is used as the default application icon. Only the > first two are installed into / as Cygwin.ico and Cygwin-Terminal.ico. > > See below for the patch. Attached are the new ico files for the setup > repository. If that's fine with everybody, Andy will also have to > change the mintty postinstall script so that the mintty entry is not > added to the start menu anymore.
Builds fine for me, and works as advertised with new pretty icons. One thing of note: I haven't locally built setup since January, and even after stripping and upx'ing: -rwxrwxr-x 1 user group 889K Aug 3 11:33 setup.exe* -rwxrwxr-x 1 user group 648K Jan 26 2011 setup.exe-save* Most -- but not all -- of that is due to the new icons, which are only: -rw-rw-r-- 1 user group 34K Aug 3 11:20 cygwin.ico -rw-rw-r-- 1 user group 65K Aug 3 11:20 cygwin-setup.ico -rw-rw-r-- 1 user group 80K Aug 3 11:20 cygwin-terminal.ico I guess Jon's changes have added a lot of code :-) I'll wait until (a) a new setup with these changes and new icons has been 'officially' released, and (b) it's had time to 'settle', before attempting to add the new ico's to the cygicons dll. -- Chuck
