Corinna Vinschen writes: > Replace numerical constants with character literals.
Sure, but only those that should represent characters. The shift lengths for instance need to be kept as integers. > Alternatively, what about using UCHAR_MAX? There's an implicit assumption that the character is 8bits wide, so using that constant seems to conceal that. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Waldorf MIDI Implementation & additional documentation: http://Synth.Stromeko.net/Downloads.html#WaldorfDocs