On 11/17/2017 8:48 AM, Ken Brown wrote:
which that fails. Also, you shouldn't be relying on the servername field being filled in.
One further comment about the servername field: AFAICT, the only use that's made of this field is to distinguish "official" mirrors (those listed in mirrors.lst, either now or in the past) from sites added by the user. See 'check_dropped_mirrors()' and 'write_cache_list()' in site.cc.
I find this confusing, and it apparently threw Brian off also. Moreover, it seems to be undocumented. I suggest either documenting this or changing it. My preference is to change it, but I'm still thinking about how to best do that. I'll probably send a patch later.
Ken
